@mdgeorge4153 review of package-alt #22074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
changed the title
mdgeorge4153
force-pushed
the
mdgeorge/package-alt-review
branch
from
4f4e8af to
385b24a
Compare
| @@ -71,6 +78,7 @@ pub struct PinnedGitDependency { | |||
|
|
|||
| /// Helper struct that represents a Git repository, with extra information about which folder to | |||
| /// checkout. | |||
| // TODO: how is this different from [UnpinnedGitDependency]? | |||
There was a problem hiding this comment.
it has git related operations, rather than dependency operations. To me, I feel like these are separate things.
| // trait method to return a resolver object, and then a method on the resolver object to | ||
| // resolve a bunch of dependencies (resolvers could implement Eq) | ||
| // | ||
| // TODO: maybe rename ManifestDependencyInfo to UnpinnedDependency |
There was a problem hiding this comment.
I think that would be good, yes!
mdgeorge4153
force-pushed
the
mdgeorge/package-alt-review
branch
from
2d5acb1 to
67fa6d3
Compare
mdgeorge4153
force-pushed
the
mdgeorge/package-alt-review
branch
from
67fa6d3 to
75176c7
Compare
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mdgeorge4153
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
stefan-mysten
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdgeorge review of package-alt, adding TODOs
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.