review progress

Author: mdgeorge4153

external-crates/move/crates/move-package-alt/TODO.md

@@ -13,7 +13,7 @@ Needs review
  - [X] dependency/dependency_set.rs
  - [X] dependency/mod.rs
  - [X] dependency/local.rs
- - [ ] dependency/git.rs
+ - [X] dependency/git.rs - will rereview with cleanup PR
 
  - [ ] dependency/external.rs
  - [ ] mocks/mock-resolver.rs

external-crates/move/crates/move-package-alt/src/dependency/git.rs

@@ -142,6 +142,7 @@ impl GitRepo {
         self.rev.as_deref()
     }
 
+    // TODO: needs a comment
     pub fn package_set_path(&self) -> &PathBuf {
         &self.path
     }
@@ -172,6 +173,7 @@ impl GitRepo {
     }
 
     /// Used for testing to be able to specify which folder to fetch to. Use `fetch` for all other needs.
+    // TODO: should be non-pub
     pub async fn fetch_to_folder(&self, fetch_to_folder: PathBuf) -> PackageResult<PathBuf> {
         self.fetch_impl(Some(fetch_to_folder)).await
     }

external-crates/move/crates/move-package-alt/src/package/mod.rs

@@ -22,6 +22,8 @@ use lockfile::{Lockfile, Publication};
 use manifest::Manifest;
 use tracing::debug;
 
+// TODO: we might want to use [move_core_types::Identifier] here, particularly for `PackageName`.
+// This will force us to maintain invariants.
 pub type EnvironmentName = String;
 pub type PackageName = String;