refactor: make model_id optional on FeatureNotSupportedError #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2025
This was referenced Oct 21, 2025
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
v2-docs | b948f50 | Oct 24 2025, 05:37 PM |
teamdandelion
force-pushed
the
10-20-test_prepare_e2e_test_for_image_recognition
branch
from
85dc8de to
fdf02ee
Compare
teamdandelion
force-pushed
the
10-21-refactor_make_model_id_optional_on_featurenotsupportederror
branch
from
29566a8 to
c61aaea
Compare
This was referenced Oct 21, 2025
koxudaxi
approved these changes
Oct 22, 2025
willbakst
approved these changes
Oct 22, 2025
teamdandelion
force-pushed
the
10-20-test_prepare_e2e_test_for_image_recognition
branch
from
fdf02ee to
ee70f5c
Compare
teamdandelion
force-pushed
the
10-21-refactor_make_model_id_optional_on_featurenotsupportederror
branch
from
c61aaea to
c22ce9f
Compare
This was referenced Oct 23, 2025
teamdandelion
force-pushed
the
10-20-test_prepare_e2e_test_for_image_recognition
branch
from
ee70f5c to
749469c
Compare
teamdandelion
force-pushed
the
10-21-refactor_make_model_id_optional_on_featurenotsupportederror
branch
2 times, most recently
from
442aca8 to
0d699a0
Compare
teamdandelion
force-pushed
the
10-20-test_prepare_e2e_test_for_image_recognition
branch
from
749469c to
4de723e
Compare
Merge activity
|
teamdandelion
changed the base branch from
10-20-test_prepare_e2e_test_for_image_recognition
to
graphite-base/1449
When the provider does not have support for a feature whatsoever (regardless of model), I don't think model_id needs to be on the FeatureNotSupportedError.
teamdandelion
force-pushed
the
10-21-refactor_make_model_id_optional_on_featurenotsupportederror
branch
from
0d699a0 to
b948f50
Compare
teamdandelion
deleted the
10-21-refactor_make_model_id_optional_on_featurenotsupportederror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the provider does not have support for a feature whatsoever
(regardless of model), I don't think model_id needs to be on the
FeatureNotSupportedError.