test: refactor all e2e tests to catch exceptions #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all the e2e tests catch exceptions rather than failing if a provider throws an error (excepting VCR over-write errors which the exception serializer re-throws). The intent of this change is it becomes possible to e.g. add a partially implemented provider to the list of providers being tested, knowing that it will throw exceptions on many tests, and then progressively implementing those features. While still maintaining a green build every step of the way.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
v2-docs | 89b1ddc | Oct 23 2025, 03:31 AM |
This was referenced Oct 20, 2025
koxudaxi
approved these changes
Oct 21, 2025
willbakst
reviewed
Oct 21, 2025
willbakst
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
Merge activity
|
teamdandelion
deleted the
10-20-test_refactor_all_e2e_tests_to_catch_exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all the e2e tests catch exceptions rather than failing if a provider
throws an error (excepting VCR over-write errors which the exception
serializer re-throws).
The intent of this change is it becomes possible to e.g. add a partially
implemented provider to the list of providers being tested, knowing that
it will throw exceptions on many tests, and then progressively
implementing those features. While still maintaining a green build every
step of the way.