Skip to content

fix: Don't use link escape chars when no tty #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
+9 −2
Merged

fix: Don't use link escape chars when no tty #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nixpkgs_review/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def print_console(self, pr: int | None) -> None:
if pr is not None:
pr_url = f"https://github.com/NixOS/nixpkgs/pull/{pr}"
info("\nLink to currently reviewing PR:")
Comment on lines 329 to 330
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pr_url = f"https://github.com/NixOS/nixpkgs/pull/{pr}"
info("\nLink to currently reviewing PR:")
info("\nLink to currently reviewing PR:")

link(f"\u001b]8;;{pr_url}\u001b\\{pr_url}\u001b]8;;\u001b\\\n")
link(pr_url)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link(pr_url)
link(f"https://github.com/NixOS/nixpkgs/pull/{pr}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale for this suggestion being?.. Either way seems fine, so unless there's a strong reason, I'd stick to status-quo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the python virtual stack machine these two are nearly identical, but the former preserves git blame and may in the future see re-use


for system, report in self.system_reports.items():
info(f"--------- Report for '{system}' ---------")
Expand Down
9 changes: 8 additions & 1 deletion nixpkgs_review/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ def wrapper(text: str) -> None:
warn = color_text(31, file=sys.stderr)
info = color_text(32)
skipped = color_text(33)
link = color_text(34)


def link(text: str) -> None:
f = color_text(34)
if HAS_TTY:
f(f"\u001b]8;;{text}\u001b\\{text}\u001b]8;;\u001b\\\n")
else:
f(text)


def sh(
Expand Down