fix: Don't use link escape chars when no tty #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Comment on lines
329
to
330
| pr_url = f"https://github.com/NixOS/nixpkgs/pull/{pr}" | ||
| info("\nLink to currently reviewing PR:") |
There was a problem hiding this comment.
Suggested change
| pr_url = f"https://github.com/NixOS/nixpkgs/pull/{pr}" | |
| info("\nLink to currently reviewing PR:") | |
| info("\nLink to currently reviewing PR:") |
| pr_url = f"https://github.com/NixOS/nixpkgs/pull/{pr}" | ||
| info("\nLink to currently reviewing PR:") | ||
| link(f"\u001b]8;;{pr_url}\u001b\\{pr_url}\u001b]8;;\u001b\\\n") | ||
| link(pr_url) |
There was a problem hiding this comment.
Suggested change
| link(pr_url) | |
| link(f"https://github.com/NixOS/nixpkgs/pull/{pr}") |
There was a problem hiding this comment.
Rationale for this suggestion being?.. Either way seems fine, so unless there's a strong reason, I'd stick to status-quo.
There was a problem hiding this comment.
To the python virtual stack machine these two are nearly identical, but the former preserves git blame and may in the future see re-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.