Add some QoL options to auto-walk

[chri-k]

Type of change

• Bug fix
• New feature

Description

Adds options to disable auto-walk when a movement key is pressed and on vertical movement, adds option to disallow movement into unloaded chunks (set by default)

Related issues

#5439
#5438

How Has This Been Tested?

works*. interaction of unloaded chunk prevention with anticheats not tested, fix already exists in case it's broken.

* GuiMove causes the emission of a KeyEvent with KeyAction.Press for held movement keys when the player inventory is opened (no other GUI produces the same result), which causes disable-on-input to trigger on that. (fixed by #5480)

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.

[Wide-Cat]

Add a listener for MouseButtonEvent as well, since it's possible people have movement keys bound to mouse buttons.

[Wide-Cat]

Can you elaborate on the issue to do with GuiMove emitting key events while you move with the player inventory open, but not with any other screens? Looking at the GuiMove code I don't really see any reason why if you are able to move with a screen open it would not emit key events.

[chri-k]

you misread that. the issue is not that it doesn't emit key events, but that it emits fake ones.

GuiMove emits KeyEvent whenever it changes the state of a key. apparently this was added 3 years ago by minegame to fix some issue with FreeCam.

AutoWalk happens to trigger this when the inventory is opened, causing an unexpected KeyEvent to be emitted for the movement key of the direction it is walking in.

at the moment there is no good way to tell whether the key was actually pressed, since many modules alter the key states (and in this case the event is emitted immediately after GuiMove itself overrides the key state)

[chri-k]

making KeyEvent keep track of whether it is synthesized or not is the easiest solution, and should be good enough (there are hypothetical situations where it isn't, but realistically it is)