chore: Improve account list performance

[owencraston]

Description

This is a minor PR that aims to improve the rendering performance of the AccountsList component with some basic tricks. This PR has no functional differences with what is already in main.

1. extract inline functions into their own variables so that they can be memoized
2. remove the need to iterate over all the accounts in the AccountsController. Instead we simple lookup the account via address.
3. memoize the component
4. memoize the icon selector with a shallow equal.

None of these will make massive improvements but they are best practices and could give us small benefits. It also makes the component easier to reason about.

Related issues

Fixes:

Manual testing steps

1. create/import a wallet
2. click on the selected account at the top of the screen
3. once the account list opens, all of your accounts with the correct names and balances should render
4. selecting a new account should change your selected account
5. editing an account name should properly change the name in the list and the home page.

Screenshots/Recordings

Before

After

screen-20250425-203650.mp4

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9c3b255
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1c178c6-ca67-49be-8b17-3033c3afbb5a

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud