You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor PR that aims to improve the rendering performance of the AccountsList component with some basic tricks. This PR has no functional differences with what is already in main.
extract inline functions into their own variables so that they can be memoized
remove the need to iterate over all the accounts in the AccountsController. Instead we simple lookup the account via address.
memoize the component
memoize the icon selector with a shallow equal.
None of these will make massive improvements but they are best practices and could give us small benefits. It also makes the component easier to reason about.
Related issues
Fixes:
Manual testing steps
create/import a wallet
click on the selected account at the top of the screen
once the account list opens, all of your accounts with the correct names and balances should render
selecting a new account should change your selected account
editing an account name should properly change the name in the list and the home page.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-performanceIssues relating to slowness of app, cpu usage, and/or blank screens.No QA NeededApply this label when your PR does not need any QA effort.no-changelogIndicates no external facing user changes, therefore no changelog documentation neededrelease-7.47.0Issue or pull request that will be included in release 7.47.0Run Smoke E2ERequires smoke E2E testingteam-accounts
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
owencraston
changed the title
metamaskbot
added
the
release-7.47.0
gantunesr
added
the
area-performance
Description
This is a minor PR that aims to improve the rendering performance of the AccountsList component with some basic tricks. This PR has no functional differences with what is already in main.
None of these will make massive improvements but they are best practices and could give us small benefits. It also makes the component easier to reason about.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
screen-20250425-203650.mp4
Pre-merge author checklist
Pre-merge reviewer checklist