better testing

Author: owencraston

app/components/UI/AccountSelectorList/AccountSelectorList.constants.ts

@@ -0,0 +1 @@
+export const ACCOUNT_SELECTOR_LIST_TESTID = 'account-selector-list';

app/components/UI/AccountSelectorList/AccountSelectorList.test.tsx

@@ -20,6 +20,7 @@ import { AccountSelectorListProps } from './AccountSelectorList.types';
 import Engine from '../../../core/Engine';
 import { CellComponentSelectorsIDs } from '../../../../e2e/selectors/wallet/CellComponent.selectors';
 import { KeyringTypes } from '@metamask/keyring-controller';
+import { ACCOUNT_SELECTOR_LIST_TESTID } from './AccountSelectorList.constants';
 
 const BUSINESS_ACCOUNT = '0xC4955C0d639D99699Bfd7Ec54d9FaFEe40e4D272';
 const PERSONAL_ACCOUNT = '0xd018538C87232FF95acbCe4870629b75640a78E7';
@@ -652,7 +653,7 @@ describe('AccountSelectorList', () => {
     );
 
     // Simply check if the component renders
-    expect(getByTestId('flat-list')).toBeDefined();
+    expect(getByTestId(ACCOUNT_SELECTOR_LIST_TESTID)).toBeDefined();
   });
 
   it('renders in select-without-menu mode', async () => {
@@ -930,7 +931,7 @@ describe('AccountSelectorList', () => {
     );
 
     // Get the FlatList and trigger content size change
-    const flatList = getByTestId('flat-list');
+    const flatList = getByTestId(ACCOUNT_SELECTOR_LIST_TESTID);
     flatList.props.onContentSizeChange();
 
     // Verify that scrollToOffset was not called

app/components/UI/AccountSelectorList/AccountSelectorList.tsx

@@ -36,6 +36,7 @@ import styleSheet from './AccountSelectorList.styles';
 import { AccountListBottomSheetSelectorsIDs } from '../../../../e2e/selectors/wallet/AccountListBottomSheet.selectors';
 import { WalletViewSelectorsIDs } from '../../../../e2e/selectors/wallet/WalletView.selectors';
 import { RootState } from '../../../reducers';
+import { ACCOUNT_SELECTOR_LIST_TESTID } from './AccountSelectorList.constants';
 
 const AccountSelectorList = ({
   onSelectAccount,
@@ -318,7 +319,7 @@ const AccountSelectorList = ({
       renderItem={renderAccountItem}
       // Increasing number of items at initial render fixes scroll issue.
       initialNumToRender={999}
-      testID="flat-list"
+      testID={ACCOUNT_SELECTOR_LIST_TESTID}
       {...props}
     />
   );

app/components/UI/AccountSelectorList/__snapshots__/AccountSelectorList.test.tsx.snap

@@ -51,7 +51,7 @@ exports[`AccountSelectorList renders all accounts with balances 1`] = `
   renderScrollComponent={[Function]}
   scrollEventThrottle={50}
   stickyHeaderIndices={[]}
-  testID="flat-list"
+  testID="account-selector-list"
   viewabilityConfigCallbackPairs={[]}
 >
   <View>
@@ -844,7 +844,7 @@ exports[`AccountSelectorList renders all accounts with right accessory 1`] = `
   renderScrollComponent={[Function]}
   scrollEventThrottle={50}
   stickyHeaderIndices={[]}
-  testID="flat-list"
+  testID="account-selector-list"
   viewabilityConfigCallbackPairs={[]}
 >
   <View>
@@ -1521,7 +1521,7 @@ exports[`AccountSelectorList renders correctly 1`] = `
   renderScrollComponent={[Function]}
   scrollEventThrottle={50}
   stickyHeaderIndices={[]}
-  testID="flat-list"
+  testID="account-selector-list"
   viewabilityConfigCallbackPairs={[]}
 >
   <View>

app/components/Views/AccountPermissions/__snapshots__/AccountPermissions.test.tsx.snap

@@ -211,6 +211,7 @@ exports[`AccountPermissions renders correctly 1`] = `
         renderScrollComponent={[Function]}
         scrollEventThrottle={50}
         stickyHeaderIndices={[]}
+        testID="account-selector-list"
         viewabilityConfigCallbackPairs={[]}
       >
         <View />