Skip to content

Pr io revamp #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ jobs:
- name: Cargo clippy
working-directory: ${{ matrix.package }}
run: |
# to be suppressed when C SDK API_LEVEL_24 is available in dev-tools
git clone https://github.com/LedgerHQ/ledger-secure-sdk.git --branch API_LEVEL_24 --single-branch c_sdk
echo "setting LEDGER_SDK_PATH to $(realpath c_sdk)"
export LEDGER_SDK_PATH=$(realpath c_sdk)
# ####################################### #
cargo clippy --target ${{ matrix.target }}

format:
Expand Down Expand Up @@ -57,7 +62,15 @@ jobs:
- name: Cargo build
working-directory: ledger_device_sdk
run: |
# to be suppressed when C SDK API_LEVEL_24 is available in dev-tools
git clone https://github.com/LedgerHQ/ledger-secure-sdk.git --branch API_LEVEL_24 --single-branch c_sdk
echo "setting LEDGER_SDK_PATH to $(realpath c_sdk)"
export LEDGER_SDK_PATH=$(realpath c_sdk)
# ####################################### #
cargo build --target ${{ matrix.target }}
if [[ "${{ matrix.target }}" == "nanosplus" || "${{ matrix.target }}" == "nanox" ]]; then
cargo build --target ${{ matrix.target }} --features nano_nbgl;
fi

test:
name: Run unit and integration tests
Expand All @@ -73,10 +86,17 @@ jobs:
- name: Unit tests
working-directory: ledger_device_sdk
run: |
cargo test --target ${{ matrix.target }} --features speculos --tests
# to be suppressed when C SDK API_LEVEL_24 is available in dev-tools
git clone https://github.com/LedgerHQ/ledger-secure-sdk.git --branch API_LEVEL_24 --single-branch c_sdk
echo "setting LEDGER_SDK_PATH to $(realpath c_sdk)"
export LEDGER_SDK_PATH=$(realpath c_sdk)
pip install -U speculos --break-system-packages
# ####################################### #
cargo test --target ${{ matrix.target }} --features speculos,debug --tests

build-apps:
name: Build all Rust apps
uses: ./.github/workflows/reusable_build_all_apps.yml
with:
rust_sdk_branch: ${{ github.ref }}
c_sdk_branch: API_LEVEL_24
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ledger_device_sdk/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ledger_device_sdk"
version = "1.22.14"
version = "1.23.0"
authors = ["yhql", "yogh333", "agrojean-ledger", "kingofpayne"]
edition = "2021"
license.workspace = true
Expand All @@ -21,7 +21,7 @@ rand_core = { version = "0.6.3", default-features = false }
zeroize = { version = "1.6.0", default-features = false }
numtoa = "0.2.4"
const-zero = "0.1.1"
ledger_secure_sdk_sys = { path = "../ledger_secure_sdk_sys", version = "1.8.3" }
ledger_secure_sdk_sys = { path = "../ledger_secure_sdk_sys", version = "1.9.0" }

[features]
debug = []
Expand Down
14 changes: 0 additions & 14 deletions ledger_device_sdk/src/ble.rs

This file was deleted.

Loading
Loading