Pr io revamp #266
Merged
Pr io revamp #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sportron-ledger
force-pushed
the
pr-io-revamp
branch
4 times, most recently
from
76cb5bd to
750c620
Compare
yogh333
reviewed
Jul 2, 2025
yogh333
reviewed
Jul 2, 2025
yogh333
reviewed
Jul 2, 2025
| #[cfg(not(any(target_os = "stax", target_os = "flex")))] | ||
| use ledger_secure_sdk_sys::buttons::{get_button_event, ButtonEvent, ButtonsState}; | ||
| use ledger_secure_sdk_sys::seph as sys_seph; | ||
| use ledger_secure_sdk_sys::*; | ||
|
|
||
| use crate::seph; | ||
|
|
||
| #[cfg(any(target_os = "nanox", target_os = "stax", target_os = "flex"))] | ||
| use crate::seph::ItcUxEvent; |
There was a problem hiding this comment.
is this used to manage BLE connection?
yogh333
reviewed
Jul 8, 2025
| @@ -32,5 +32,5 @@ pub fn screen_update() { | |||
| #[cfg(not(feature = "speculos"))] | |||
| pub fn seph_setup_ticker(interval_ms: u16) { | |||
| let ms = interval_ms.to_be_bytes(); | |||
There was a problem hiding this comment.
is this function still needed ? It is never called by any other SDK modules or external apps
yogh333
force-pushed
the
pr-io-revamp
branch
2 times, most recently
from
219273a to
f097c39
Compare
(cherry picked from commit f48979a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.