-
Notifications
You must be signed in to change notification settings - Fork 68
[PLT-46] Add method / heurisrtics to extract original sdk method name from python trace #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3761e58
to
04700d7
Compare
).__class__.__name__ | ||
|
||
if method_name not in skip_methods and class_name not in skip_classes: | ||
if "test" in call_info.filename: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test for a match against .*_test.py
or something, so we don't accidentally catch latest_whatever.py
(e.g.) here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point ok
@@ -186,6 +221,9 @@ def convert_value(value): | |||
if files: | |||
del headers["Content-Type"] | |||
del headers["Accept"] | |||
headers["X-SDK-Method"] = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of a nit: This is the only place we use call_info right? Can we just have it create the string directly? Or if you prefer it like this, at least replace the three calls with a single call?
bae3834
to
7b5e3b8
Compare
7b5e3b8
to
8a78550
Compare
Description
This is passed on to the api in the header and from there logged to DD in order to build dashboards
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features