Skip to content

[PLT-46] Add method / heurisrtics to extract original sdk method name from python trace #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

vbrodsky
Copy link
Contributor

Description

This is passed on to the api in the header and from there logged to DD in order to build dashboards

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner September 25, 2024 23:43
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 25, 2024 23:43 — with GitHub Actions Inactive
@vbrodsky vbrodsky force-pushed the VB/report-method-name_PLT-46 branch from 3761e58 to 04700d7 Compare September 25, 2024 23:59
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 26, 2024 00:00 — with GitHub Actions Inactive
).__class__.__name__

if method_name not in skip_methods and class_name not in skip_classes:
if "test" in call_info.filename:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test for a match against .*_test.py or something, so we don't accidentally catch latest_whatever.py (e.g.) here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point ok

@@ -186,6 +221,9 @@ def convert_value(value):
if files:
del headers["Content-Type"]
del headers["Accept"]
headers["X-SDK-Method"] = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a nit: This is the only place we use call_info right? Can we just have it create the string directly? Or if you prefer it like this, at least replace the three calls with a single call?

@vbrodsky vbrodsky force-pushed the VB/report-method-name_PLT-46 branch from 7b5e3b8 to 8a78550 Compare September 26, 2024 20:52
@vbrodsky vbrodsky temporarily deployed to Test-PyPI-lbox-clients September 26, 2024 20:53 — with GitHub Actions Inactive
@vbrodsky vbrodsky merged commit 1d78bee into v6 Sep 26, 2024
16 checks passed
@vbrodsky vbrodsky deleted the VB/report-method-name_PLT-46 branch September 26, 2024 21:06
vbrodsky added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants