Skip to content

Commit 8a78550

Browse files
author
Val Brodsky
committed
PR feedback
1 parent 04700d7 commit 8a78550

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

libs/lbox-clients/src/lbox/request_client.py

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import sys
77
from datetime import datetime, timezone
88
from types import MappingProxyType
9-
from typing import Callable, Dict, Optional
9+
from typing import Callable, Dict, Optional, TypedDict
1010

1111
import requests
1212
import requests.exceptions
@@ -25,6 +25,13 @@ def python_version_info():
2525

2626

2727
LABELBOX_CALL_PATTERN = re.compile(r"/labelbox/")
28+
TEST_FILE_PATTERN = re.compile(r".*test.*\.py$")
29+
30+
31+
class _RequestInfo(TypedDict):
32+
prefix: str
33+
class_name: str
34+
method_name: str
2835

2936

3037
def call_info():
@@ -45,7 +52,7 @@ def call_info():
4552
).__class__.__name__
4653

4754
if method_name not in skip_methods and class_name not in skip_classes:
48-
if "test" in call_info.filename:
55+
if TEST_FILE_PATTERN.search(call_info.filename):
4956
prefix = "test:"
5057
else:
5158
if class_name == "NoneType":
@@ -54,7 +61,12 @@ def call_info():
5461

5562
except Exception:
5663
pass
57-
return (prefix, class_name, method_name)
64+
return _RequestInfo(prefix=prefix, class_name=class_name, method_name=method_name)
65+
66+
67+
def call_info_as_str():
68+
info = call_info()
69+
return f"{info['prefix']}{info['class_name']}:{info['method_name']}"
5870

5971

6072
class RequestClient:
@@ -221,9 +233,8 @@ def convert_value(value):
221233
if files:
222234
del headers["Content-Type"]
223235
del headers["Accept"]
224-
headers["X-SDK-Method"] = (
225-
f"{call_info()[0]}{call_info()[1]}:{call_info()[2]}"
226-
)
236+
headers["X-SDK-Method"] = call_info_as_str()
237+
227238
request = requests.Request(
228239
"POST",
229240
endpoint,

0 commit comments

Comments
 (0)