Skip to content

Vb/refactor client plt 1385 2 #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/labelbox/exceptions.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Exceptions
===============================================================================================

.. automodule:: labelbox.exceptions
.. automodule:: lbox.exceptions
:members:
:show-inheritance:
1 change: 1 addition & 0 deletions docs/labelbox/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Labelbox Python SDK Documentation
project
project-model-config
quality-mode
request-client
resource-tag
review
search-filters
Expand Down
6 changes: 6 additions & 0 deletions docs/labelbox/request-client.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Request Client
===============================================================================================

.. automodule:: lbox.request_client
:members:
:show-inheritance:
2 changes: 1 addition & 1 deletion libs/labelbox/mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ ignore_missing_imports = True
ignore_errors = True

[mypy-labelbox]
ignore_errors = True
ignore_errors = True
2 changes: 2 additions & 0 deletions libs/labelbox/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ dependencies = [
"tqdm>=4.66.2",
"geojson>=3.1.0",
"mypy==1.10.1",
"lbox-clients==1.0.0",
]
readme = "README.md"
requires-python = ">=3.8"
Expand Down Expand Up @@ -90,6 +91,7 @@ unit = "pytest tests/unit"
integration = { cmd = "pytest tests/integration" }
data = { cmd = "pytest tests/data" }
rye-fmt-check = "rye fmt --check"
MYPYPATH="../lbox-clients/src/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o.w. mypy can not find lbox-clients source codes and errors

mypy-lint = "mypy src --pretty --show-error-codes --non-interactive --install-types"
lint = { chain = ["mypy-lint", "rye-fmt-check"] }
test = { chain = ["lint", "unit", "integration"] }
Expand Down
6 changes: 3 additions & 3 deletions libs/labelbox/src/labelbox/adv_client.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import io
import json
import logging
from typing import Dict, Any, Optional, List, Callable
from typing import Any, Callable, Dict, List, Optional
from urllib.parse import urlparse
from labelbox.exceptions import LabelboxError

import requests
from requests import Session, Response
from lbox.exceptions import LabelboxError
from requests import Response, Session

logger = logging.getLogger(__name__)

Expand Down
Loading
Loading