-
Notifications
You must be signed in to change notification settings - Fork 68
Vb/refactor client plt 1385 2 #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db2b80d
to
4fd9d68
Compare
4fd9d68
to
379524b
Compare
b073a9d
to
76c2ceb
Compare
76c2ceb
to
f5ee815
Compare
f5ee815
to
f2e93a2
Compare
cdc9e6a
to
d59e03f
Compare
@@ -90,6 +91,7 @@ unit = "pytest tests/unit" | |||
integration = { cmd = "pytest tests/integration" } | |||
data = { cmd = "pytest tests/data" } | |||
rye-fmt-check = "rye fmt --check" | |||
MYPYPATH="../lbox-clients/src/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o.w. mypy can not find lbox-clients source codes and errors
exceptions.TimeoutError, | ||
) | ||
) | ||
def execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering. Is there a plan to some day refactor this beast of a function? I get dizzy each time i have to scroll through it 😄 I believe, there are few oop patterns (strategy, visitor) that could help dismantled this function and make it more simple and facilitate maintenance in the long run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tes @mihhail-m we will refactor it ... some time :)
Description
Stories:
https://labelbox.atlassian.net/browse/PLT-1385
https://labelbox.atlassian.net/browse/PLT-1552
lbox-clients
. Made adjustments across code to imports / use it, fixed mypy etcType of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features