Skip to content

Vb/refactor client plt 1385 2 #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Vb/refactor client plt 1385 2 #1834

merged 7 commits into from
Sep 20, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 19, 2024

Description

Stories:
https://labelbox.atlassian.net/browse/PLT-1385
https://labelbox.atlassian.net/browse/PLT-1552

  • Move logic to execute api request and exceptions to a separate lbox component lbox-clients. Made adjustments across code to imports / use it, fixed mypy etc
  • Added logic to execute custom error handlers for internal server errors. Not used in the main code atm

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner September 19, 2024 04:22
@vbrodsky vbrodsky force-pushed the VB/refactor-client_PLT-1385-2 branch from db2b80d to 4fd9d68 Compare September 19, 2024 04:24
@vbrodsky vbrodsky force-pushed the VB/refactor-client_PLT-1385-2 branch from 4fd9d68 to 379524b Compare September 19, 2024 04:34
@vbrodsky vbrodsky force-pushed the VB/refactor-client_PLT-1385-2 branch 2 times, most recently from b073a9d to 76c2ceb Compare September 19, 2024 16:36
@vbrodsky vbrodsky force-pushed the VB/refactor-client_PLT-1385-2 branch from 76c2ceb to f5ee815 Compare September 19, 2024 16:58
@vbrodsky vbrodsky force-pushed the VB/refactor-client_PLT-1385-2 branch from cdc9e6a to d59e03f Compare September 19, 2024 17:12
@@ -90,6 +91,7 @@ unit = "pytest tests/unit"
integration = { cmd = "pytest tests/integration" }
data = { cmd = "pytest tests/data" }
rye-fmt-check = "rye fmt --check"
MYPYPATH="../lbox-clients/src/"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o.w. mypy can not find lbox-clients source codes and errors

exceptions.TimeoutError,
)
)
def execute(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering. Is there a plan to some day refactor this beast of a function? I get dizzy each time i have to scroll through it 😄 I believe, there are few oop patterns (strategy, visitor) that could help dismantled this function and make it more simple and facilitate maintenance in the long run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tes @mihhail-m we will refactor it ... some time :)

@vbrodsky vbrodsky merged commit 2beab37 into v6 Sep 20, 2024
23 of 30 checks passed
@vbrodsky vbrodsky deleted the VB/refactor-client_PLT-1385-2 branch September 20, 2024 18:38
vbrodsky added a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants