Skip to content

[PLT-1452] Vb/fix flaky annotation test plt 1452 2 #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 10, 2024

Description

This PR finally addresses flaky test issues for LLM annotation upload projects. These projects have 2 ways of creating data rows: 'automatic' (at the time of project creation) and 'pre-created' (dataset and data rows exist).

The tests exhibited flaky behavior in the automatic mode. At times data row creation did not finish(due to load?). I updated the test to use the 'pre-created' mode for data rows.

Commits: this commit is the actual fix: 4130d32. The rest are produced by the linter

How to read sdk integration test results for this PR:
Unit tests for Python 3.12 test this change directly. It show the issue has been addressed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky changed the title Vb/fix flaky annotation test plt 1452 2 [PLT-1452] Vb/fix flaky annotation test plt 1452 2 Sep 10, 2024
@vbrodsky vbrodsky marked this pull request as ready for review September 10, 2024 16:43
@vbrodsky vbrodsky requested a review from a team as a code owner September 10, 2024 16:43
@vbrodsky vbrodsky merged commit 71f970a into develop Sep 10, 2024
16 of 26 checks passed
@vbrodsky vbrodsky deleted the VB/fix-flaky-annotation-test_PLT-1452_2 branch September 10, 2024 17:30
@vbrodsky vbrodsky restored the VB/fix-flaky-annotation-test_PLT-1452_2 branch September 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants