Skip to content

[PLT-1452] Vb/fix flaky annotation test plt 1452 #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Sep 9, 2024

Description

Addresses 'flakiness' in creating data rows for LLM project by adding a wait till the data rows are created

First commit is a fix, 2d commit is a change due to running linter on a pytest conf file

NOTE due to the nature of LLM projects, data rows are created async / offline. We try 5 times with a sleep of 1s to wait for those data rows. If data row still fails to create it would indicate an stage or backend issue, not a test issue

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky force-pushed the VB/fix-flaky-annotation-test_PLT-1452 branch from 1385359 to c845428 Compare September 9, 2024 18:36
@vbrodsky vbrodsky marked this pull request as ready for review September 9, 2024 18:36
@vbrodsky vbrodsky requested a review from a team as a code owner September 9, 2024 18:36
@vbrodsky vbrodsky changed the title Vb/fix flaky annotation test plt 1452 [PLT-1452] Vb/fix flaky annotation test plt 1452 Sep 9, 2024
Gabefire
Gabefire previously approved these changes Sep 9, 2024
@vbrodsky
Copy link
Contributor Author

#1798 will supercede this PR

@vbrodsky vbrodsky closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants