Skip to content

[PLT-1205] Add additional UG Tests / Proper Error Handling #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

adrian-chang
Copy link
Contributor

Description

  • Add better exceptions for certain user group errors
  • Fix pagination related to user group tests

** Dependent on API change

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@adrian-chang adrian-chang requested a review from a team as a code owner July 5, 2024 01:17
@adrian-chang adrian-chang force-pushed the achang/plt-1205-updates branch from 73581f0 to 1e0ccc4 Compare July 5, 2024 01:18
vbrodsky
vbrodsky previously approved these changes Jul 8, 2024
@adrian-chang adrian-chang merged commit 8d4777f into develop Jul 8, 2024
22 checks passed
@adrian-chang adrian-chang deleted the achang/plt-1205-updates branch July 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants