Skip to content

Commit a8745b4

Browse files
author
Adrian Chang
committed
Use correct method to create object
1 parent 84281ff commit a8745b4

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

libs/labelbox/src/labelbox/exceptions.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,21 @@ class AuthorizationError(LabelboxError):
3232
class ResourceNotFoundError(LabelboxError):
3333
"""Exception raised when a given resource is not found. """
3434

35-
def __init__(self, db_object_type, params):
36-
""" Constructor.
35+
def __init__(self, db_object_type=None, params=None, message=None):
36+
"""Constructor for the ResourceNotFoundException class.
3737
3838
Args:
39-
db_object_type (type): A labelbox.schema.DbObject subtype.
40-
params (dict): Dict of params identifying the sought resource.
39+
db_object_type (type): A subtype of labelbox.schema.DbObject.
40+
params (dict): A dictionary of parameters identifying the sought resource.
41+
message (str): An optional message to include in the exception.
4142
"""
42-
super().__init__("Resource '%s' not found for params: %r" %
43-
(db_object_type.type_name(), params))
44-
self.db_object_type = db_object_type
45-
self.params = params
43+
if message is not None:
44+
super().__init__(message)
45+
else:
46+
super().__init__("Resource '%s' not found for params: %r" %
47+
(db_object_type.type_name(), params))
48+
self.db_object_type = db_object_type
49+
self.params = params
4650

4751

4852
class ResourceConflict(LabelboxError):

libs/labelbox/src/labelbox/schema/user_group.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,7 @@ def get(self) -> "UserGroup":
139139
}
140140
result = self.client.execute(query, params)
141141
if not result:
142-
error = ResourceNotFoundError.__new__(ResourceNotFoundError)
143-
error.message = "Failed to get user group as user group does not exist"
144-
raise error
142+
raise ResourceNotFoundError(message="Failed to get user group as user group does not exist")
145143
self.name = result["userGroup"]["name"]
146144
self.color = UserGroupColor(result["userGroup"]["color"])
147145
self.projects = self._get_projects_set(result["userGroup"]["projects"]["nodes"])
@@ -202,9 +200,7 @@ def update(self) -> "UserGroup":
202200
try:
203201
result = self.client.execute(query, params)
204202
if not result:
205-
error = ResourceNotFoundError.__new__(ResourceNotFoundError)
206-
error.message = "Failed to update user group as user group does not exist"
207-
raise error
203+
raise ResourceNotFoundError(message="Failed to update user group as user group does not exist")
208204
except MalformedQueryException as e:
209205
raise UnprocessableEntityError("Failed to update user group") from e
210206
return self
@@ -303,9 +299,7 @@ def delete(self) -> bool:
303299
params = {"id": self.id}
304300
result = self.client.execute(query, params)
305301
if not result:
306-
error = ResourceNotFoundError.__new__(ResourceNotFoundError)
307-
error.message = "Failed to delete user group as user group does not exist"
308-
raise error
302+
raise ResourceNotFoundError(message="Failed to delete user group as user group does not exist")
309303
return result["deleteUserGroup"]["success"]
310304

311305
def get_user_groups(self) -> Iterator["UserGroup"]:

0 commit comments

Comments
 (0)