Skip to content

[PLT-1151] Vb/model setup complete #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Jun 20, 2024

Description

Provides support for a call to 'complete' chat model evaluation project, thus preventing new model configs from being added / removed. This will make sure sdk can support full model evaluation projects lifecycle on par with the UI

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky requested a review from a team as a code owner June 20, 2024 16:57
@vbrodsky vbrodsky marked this pull request as draft June 20, 2024 16:57
@vbrodsky vbrodsky force-pushed the VB/model-setup-complete_PLT-1151_2 branch from 847956a to 2b3766a Compare June 20, 2024 17:01
@vbrodsky vbrodsky force-pushed the VB/model-setup-complete_PLT-1151_2 branch 3 times, most recently from 9a956c2 to 3df91fd Compare June 20, 2024 18:02
@vbrodsky vbrodsky marked this pull request as ready for review June 20, 2024 18:07
@vbrodsky vbrodsky changed the title Vb/model setup complete plt 1151 2 [PLT-1151] Vb/model setup complete Jun 20, 2024
@vbrodsky vbrodsky force-pushed the VB/model-setup-complete_PLT-1151_2 branch 2 times, most recently from 5e3dd2a to 8216608 Compare June 26, 2024 13:18
@vbrodsky vbrodsky force-pushed the VB/model-setup-complete_PLT-1151_2 branch from 230ad15 to e795c79 Compare June 26, 2024 14:53
@vbrodsky vbrodsky force-pushed the VB/model-setup-complete_PLT-1151_2 branch from e795c79 to 63090c4 Compare June 26, 2024 14:54
@vbrodsky vbrodsky merged commit bc61745 into develop Jun 26, 2024
16 of 22 checks passed
@vbrodsky vbrodsky deleted the VB/model-setup-complete_PLT-1151_2 branch June 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants