Handle model setup complete on model project config deletion

Author: Val Brodsky

libs/labelbox/src/labelbox/exceptions.py

@@ -1,3 +1,6 @@
+import re
+
+
 class LabelboxError(Exception):
     """Base class for exceptions."""
 
@@ -147,3 +150,16 @@ class CustomMetricsNotSupportedException(Exception):
 
 class ProcessingWaitTimeout(Exception):
     """Raised when waiting for the data rows to be processed takes longer than allowed"""
+
+
+def _error_message_for_unparsed_graphql_error(error_string: str) -> str:
+    # Regex to find the message content
+    pattern = r"'message': '([^']+)'"
+    # Search for the pattern in the error string
+    match = re.search(pattern, error_string)
+    if match:
+        error_content = match.group(1)
+    else:
+        error_content = "Unknown error"
+
+    return error_content

libs/labelbox/src/labelbox/schema/project.py

@@ -1,4 +1,3 @@
-import re
 import json
 import logging
 from string import Template
@@ -14,6 +13,7 @@
 
 from labelbox import parser
 from labelbox import utils
+from labelbox.exceptions import _error_message_for_unparsed_graphql_error
 from labelbox.exceptions import (InvalidQueryError, LabelboxError,
                                  ProcessingWaitTimeout, ResourceConflict,
                                  ResourceNotFoundError)
@@ -1274,15 +1274,7 @@ def add_model_config(self, model_config_id: str) -> str:
         except LabelboxError as e:
             # unfortunately, this is the type of errors our client does not deal with and so the error message is not in the same format as the other errors
             # needs custom parsing
-            error_string = e.message
-            # Regex to find the message content
-            pattern = r"'message': '([^']+)'"
-            # Search for the pattern in the error string
-            match = re.search(pattern, error_string)
-            if match:
-                error_content = match.group(1)
-            else:
-                error_content = "Unknown error"
+            error_content = _error_message_for_unparsed_graphql_error(e.message)
             raise LabelboxError(message=error_content) from e
 
         if not result:

libs/labelbox/src/labelbox/schema/project_model_config.py

@@ -1,5 +1,6 @@
-from labelbox.orm.db_object import DbObject, Deletable
+from labelbox.orm.db_object import DbObject
 from labelbox.orm.model import Field, Relationship
+from labelbox.exceptions import LabelboxError, _error_message_for_unparsed_graphql_error
 
 
 class ProjectModelConfig(DbObject):
@@ -30,5 +31,11 @@ def delete(self) -> bool:
         params = {
             "id": self.uid,
         }
-        result = self.client.execute(query, params)
+
+        try:
+            result = self.client.execute(query, params)
+        except LabelboxError as e:
+            error_content = _error_message_for_unparsed_graphql_error(e.message)
+            raise LabelboxError(message=error_content) from e
+
         return result["deleteProjectModelConfig"]["success"]

libs/labelbox/tests/integration/test_project_set_model_setup_complete.py

@@ -19,6 +19,31 @@ def test_live_chat_evaluation_project(
         project.add_model_config(model_config.uid)
 
 
+def test_live_chat_evaluation_project_delete_cofig(
+        live_chat_evaluation_project_with_new_dataset, model_config):
+
+    project = live_chat_evaluation_project_with_new_dataset
+    project_model_config_id = project.add_model_config(model_config.uid)
+    assert project_model_config_id
+
+    project_model_config = None
+    for pmg in project.project_model_configs():
+        if pmg.uid == project_model_config_id:
+            project_model_config = pmg
+            break
+    assert project_model_config
+
+    project.set_project_model_setup_complete()
+    assert bool(project.model_setup_complete) is True
+
+    with pytest.raises(
+            expected_exception=LabelboxError,
+            match=
+            "Cannot create model config for project because model setup is complete"
+    ):
+        project_model_config.delete()
+
+
 def test_offline_chat_evaluation_project(offline_chat_evaluation_project,
                                          model_config):