Skip to content

Updated BaniList component to use 'token' for key extraction, added '… #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Updated BaniList component to use 'token' for key extraction, added '… #250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d3fd6
Updated BaniList component to use 'token' for key extraction, added '…
amitojsingh May 13, 2025
ef35ece
Enhanced BaniList component by utilizing 'token' for key extraction, …
amitojsingh May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/common/components/BaniList/BaniList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import colors from "../../colors";
import { styles } from "../../../Settings/styles";

const BaniList = React.memo(({ data, onPress }) => {
console.log("rendering BaniList", data);
const fontSize = useSelector((state) => state.fontSize);
const fontFace = useSelector((state) => state.fontFace);
const isTransliteration = useSelector((state) => state.isTransliteration);
Expand Down Expand Up @@ -75,7 +76,7 @@ const BaniList = React.memo(({ data, onPress }) => {
style={!isPotrait && Platform.OS === "ios" && { marginLeft: 30 }}
data={data}
renderItem={renderBanis}
keyExtractor={(item) => item.gurmukhi}
keyExtractor={(item) => item.token}
/>
);
});
Expand Down
1 change: 1 addition & 0 deletions src/common/components/BaniList/baniOrderHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const extractBaniDetails = (baniItem) => {
id: baniItem.id,
gurmukhi: baniItem.gurmukhi,
translit: baniItem.translit,
token: baniItem.token,
};
};
const orderedBani = (baniList, baniOrder) => {
Expand Down
1 change: 1 addition & 0 deletions src/common/defaultBaniOrder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ const defaultBaniOrder = {
{
gurmukhi: "22 vwrW",
translit: "22 varaa(n)",
token:"22vwrW"
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the token property is properly delimited; if the following property is 'folder', a trailing comma might be required to maintain valid syntax.

Suggested change
token:"22vwrW"
token:"22vwrW",

Copilot uses AI. Check for mistakes.
folder: [
{
id: 86,
Expand Down
6 changes: 4 additions & 2 deletions src/database/db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,23 @@ export const getBaniList = (language) => {
.then((db) => {
db.transaction((tx) => {
tx.executeSql(
"SELECT ID, Gurmukhi, Transliterations FROM Banis",
"SELECT ID, Gurmukhi, Token, Transliterations FROM Banis",
[],
(_tx, results) => {
const { rows } = results;
const count = rows.length;
const totalResults = [];
for (let i = 0; i < count; i += 1) {
const { ID, Gurmukhi, Transliterations } = rows.item(i);
const { ID, Gurmukhi, Transliterations, Token } = rows.item(i);

totalResults.push({
id: ID,
gurmukhi: Gurmukhi,
token: Token,
translit: getTranslitText(Transliterations, language),
});
}
console.log("Bani List", totalResults);
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The debug logging statement may be unintentionally left in production code; consider removing it or wrapping it under a debug flag.

Suggested change
console.log("Bani List", totalResults);
if (process.env.DEBUG) {
logMessage("Bani List", totalResults);
}

Copilot uses AI. Check for mistakes.
resolve(totalResults);
},
(error) => {
Expand Down