Updated BaniList component to use 'token' for key extraction, added '… #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token' field to Bani details extraction, and modified database query to include 'Token' field.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BaniList component and related files to include a new "token" field for key extraction and details display in the Bani data. Key changes include:
- Modifying the database query in db.js to select the Token column and include it in the result objects.
- Adding a token property in the default Bani order and updating the extraction helper accordingly.
- Changing the key extractor in BaniList.jsx to use the token field, with an added console log for debugging.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/database/db.js | Updated SQL query and object construction to include token. |
| src/common/defaultBaniOrder.js | Added token property in the default order object. |
| src/common/components/BaniList/baniOrderHelper.js | Included token in the bani item details extraction. |
| src/common/components/BaniList/BaniList.jsx | Changed key extraction to use token and added debug logging. |
| translit: getTranslitText(Transliterations, language), | ||
| }); | ||
| } | ||
| console.log("Bani List", totalResults); |
There was a problem hiding this comment.
[nitpick] The debug logging statement may be unintentionally left in production code; consider removing it or wrapping it under a debug flag.
Suggested change
| console.log("Bani List", totalResults); | |
| if (process.env.DEBUG) { | |
| logMessage("Bani List", totalResults); | |
| } |
src/common/defaultBaniOrder.js
Outdated
| { | ||
| gurmukhi: "22 vwrW", | ||
| translit: "22 varaa(n)", | ||
| token:"22vwrW" |
There was a problem hiding this comment.
Ensure that the token property is properly delimited; if the following property is 'folder', a trailing comma might be required to maintain valid syntax.
Suggested change
| token:"22vwrW" | |
| token:"22vwrW", |
…added 'token' field to Bani details, and updated folder handling in baniOrderHelper for improved data structure consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…token' field to Bani details extraction, and modified database query to include 'Token' field.