Skip to content

fix: updating the testcontainer dep #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: updating the testcontainer dep #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef1d56
fix: docker image tag for develop updated
Dudleyneedham May 17, 2024
dd53af1
fix: updating the get started test container
Dudleyneedham May 17, 2024
485639e
fix: updating the get started test container
Dudleyneedham May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# `docker-compose run sdk` will run integration tests using the latest
# standalone-node image on dockerhub. The src/ directory is mounted, so rebuilding
# is not required to integrate changes in this directory.
# `docker-compose run sdk yarn test:integration:run Attestation` would run specific tests.
# `docker-compose run sdk yarn test:integration:latest-develop Attestation` would run specific tests.
# In order to test against the current state of the develop branch, you can build a standalone-node
# image locally by telling docker-compose to use the override file `dc.build.node.yml` like so:
# `docker-compose -f docker-compose.yml -f dc.build.node.yml run sdk`. Alternatively you could
Expand All @@ -13,7 +13,7 @@ version: '3.2'

services:
dev-node:
image: kiltprotocol/standalone-node:develop
image: kiltprotocol/standalone-node:latest-develop
command: '--dev --ws-port 9944 --ws-external'

sdk:
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export async function getStartedTestContainer(
process.env.TESTCONTAINERS_NODE_IMG || 'kiltprotocol/standalone-node'
console.log(`using testcontainer with image ${image}`)
const strategies = [
['--dev', '--ws-external', `--ws-port=${WS_PORT}`],
// ['--dev', '--ws-external', `--ws-port=${WS_PORT}`],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to figure out why the test container isn't loading. To active the CI and see what is happening and why the container isn't loading.

['--dev', '--rpc-external', `--rpc-port=${WS_PORT}`],
]
// eslint-disable-next-line no-restricted-syntax
Expand All @@ -61,7 +61,7 @@ export async function getStartedTestContainer(
console.log('container started and ready')
return started
} catch (error) {
console.warn(
throw console.error(
'Failed to start container due to the following error:\n',
error
)
Expand Down
Loading