fix: updating the testcontainer dep #864
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
reviewed
May 20, 2024
| @@ -41,7 +41,7 @@ export async function getStartedTestContainer( | |||
| process.env.TESTCONTAINERS_NODE_IMG || 'kiltprotocol/standalone-node' | |||
| console.log(`using testcontainer with image ${image}`) | |||
| const strategies = [ | |||
| ['--dev', '--ws-external', `--ws-port=${WS_PORT}`], | |||
| // ['--dev', '--ws-external', `--ws-port=${WS_PORT}`], | |||
There was a problem hiding this comment.
Trying to figure out why the test container isn't loading. To active the CI and see what is happening and why the container isn't loading.
Dudleyneedham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3410
Tag wasn't updated in develop
https://hub.docker.com/r/kiltprotocol/standalone-node/tags?page=&page_size=&ordering=&name=develop
Found out that the branch doesn't use the docker images anymore and direct to testcontainer.
How to test:
Run the docker compose and check to see if working.
Checklist: