Skip to content

Automatic lookup of DOI at citation relations #13539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 20, 2025
Merged

Automatic lookup of DOI at citation relations #13539

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec864d3
Some initial changes + split of the placeholder to label and hyperlink.
ankamde Jul 12, 2025
365b4fa
Commit before switching to different branch.
ankamde Jul 13, 2025
a24dd53
Cited by panel ready.
ankamde Jul 13, 2025
4ef4dd4
Cited by panel ready.
ankamde Jul 13, 2025
af8b918
Finished DOI lookup, add notification about not found DOI.
ankamde Jul 14, 2025
5fa2d72
Add messages to JabRef_en.properties. Modified lang files rolled back.
ankamde Jul 16, 2025
927664c
Merge branch 'main' into issue-13234-automatic-lookup-of-DOI-at-citat…
ankamde Jul 16, 2025
dfdec86
Change "Up" to "up" in the messages.
ankamde Jul 16, 2025
43e1ce7
Remove exclamation from the message.
ankamde Jul 16, 2025
487e1fb
Move methods to the original place in the file.
ankamde Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Added

- We added automatic lookup of DOI at citation relations [#13234](https://github.com/JabRef/jabref/issues/13234)
- We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189)
- We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842)
- When adding an entry to a library, a warning is displayed if said entry already exists in an active library. [#13261](https://github.com/JabRef/jabref/issues/13261)
Expand Down
19 changes: 19 additions & 0 deletions jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationComponents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package org.jabref.gui.entryeditor.citationrelationtab;

import javafx.scene.control.Button;
import javafx.scene.control.ProgressIndicator;

import org.jabref.logic.importer.fetcher.citation.CitationFetcher;
import org.jabref.model.entry.BibEntry;

import org.controlsfx.control.CheckListView;

public record CitationComponents(
BibEntry entry,
CheckListView<CitationRelationItem> listView,
Button abortButton,
Button refreshButton,
CitationFetcher.SearchType searchType,
Button importButton,
ProgressIndicator progress) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI component (ProgressIndicator) should not be directly included in a data structure. This violates separation of concerns and should be managed in a dedicated UI controller.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simple parameter object - instead passing 7 parameters, use dedicated object.

}
381 changes: 198 additions & 183 deletions ...ui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_de.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2719,7 +2719,8 @@ Get\ more\ themes...=Weitere Designs erhalten ...
Miscellaneous=Verschiedenes
File-related=Datei-bezogen

The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=Der ausgewählte Eintrag hat keine DOI verlinkt. Suchen Sie eine DOI und versuchen Sie es erneut.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=Der ausgewählte Eintrag hat keine DOI verlinkt.
Look\ Up\ a\ DOI\ and\ try\ again.=Suchen Sie eine DOI und versuchen Sie es erneut.
Cited\ By=Zitiert von
Cites=Zitate
No\ articles\ found=Keine Artikel gefunden
Expand Down
3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2792,7 +2792,8 @@ Miscellaneous=Miscellaneous
File-related=File-related

Add\ selected\ entry(s)\ to\ library=Add selected entry(s) to library
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=The selected entry doesn't have a DOI linked to it. Lookup a DOI and try again.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=The selected entry doesn't have a DOI linked to it.
Look\ Up\ a\ DOI\ and\ try\ again.=Lookup a DOI and try again.
Cited\ By=Cited By
Cites=Cites
No\ articles\ found=No articles found
Expand Down
3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_es.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2364,7 +2364,8 @@ Writing\ metadata\ to\ %0=Escribiendo metadatos a %0
Get\ more\ themes...=Obtener más temas...


The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=La entrada seleccionada no tiene ningún DOI enlazado. Busque un DOI e inténtelo de nuevo.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=La entrada seleccionada no tiene ningún DOI enlazado.
Look\ Up\ a\ DOI\ and\ try\ again.=Busque un DOI e inténtelo de nuevo.
Cited\ By=Citado por
No\ articles\ found=No se encontró ningún artículo
Restart\ search=Reiniciar búsqueda
Expand Down
3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_fr.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2791,7 +2791,8 @@ Miscellaneous=Divers
File-related=Lié au fichier

Add\ selected\ entry(s)\ to\ library=Ajouter les entrées sélectionnées à la bibliothèque
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=L'entrée sélectionnée ne contient pas de DOI. Recherchez un DOI et réessayez.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=L'entrée sélectionnée ne contient pas de DOI.
Look\ Up\ a\ DOI\ and\ try\ again.=Recherchez un DOI et réessayez.
Cited\ By=Cité par
Cites=Citations
No\ articles\ found=Pas d'article trouvé
Expand Down
3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_it.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2764,7 +2764,8 @@ Miscellaneous=Varie
File-related=Correlato al file

Add\ selected\ entry(s)\ to\ library=Aggiungi la/e voce/i selezionata/e alla libreria
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=La voce selezionata non ha un DOI collegato ad essa. Cerca un DOI e riprova.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=La voce selezionata non ha un DOI collegato ad essa.
Look\ Up\ a\ DOI\ and\ try\ again.=Cerca un DOI e riprova.
Cited\ By=Citato da
Cites=Citazioni
No\ articles\ found=Nessun articolo trovato
Expand Down
3 changes: 2 additions & 1 deletion jablib/src/main/resources/l10n/JabRef_pt_BR.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2791,7 +2791,8 @@ Miscellaneous=Diversos
File-related=Arquivo relacionado

Add\ selected\ entry(s)\ to\ library=Adicionar as referências selecionadas à biblioteca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to go through crowdin web site to update translations....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me have a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the PR is merged, the new translations will be synced with crowdin and you can translat them there https://crowdin.com/project/jabref

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koppor @Siedlerchr Could you raise an issue to address the new translations with Crowdin and assign it to me, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need that for a university course? Typically Crowdin just works.

The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=A entrada selecionada não tem um DOI vinculado a ele. Verifique um DOI e tente novamente.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=A entrada selecionada não tem um DOI vinculado a ele.
Look\ Up\ a\ DOI\ and\ try\ again.=Verifique um DOI e tente novamente.
Cited\ By=Citado por
Cites=Citar
No\ articles\ found=Nenhum artigo encontrado
Expand Down
4 changes: 2 additions & 2 deletions jablib/src/main/resources/l10n/JabRef_tr.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2403,8 +2403,8 @@ Writing\ metadata\ to\ %0=Metaverisi %0'e yazılıyor

Get\ more\ themes...=Daha fazla tema getir...


The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=Seçili girdiyle bağlantılı bir DOI yok. Bir DOI arayıp tekrar deneyin.
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=Seçili girdiyle bağlantılı bir DOI yok.
Look\ Up\ a\ DOI\ and\ try\ again.=Bir DOI arayıp tekrar deneyin.
Cited\ By=Tarafından atfedilmiş
No\ articles\ found=Makale bulunamadı
Restart\ search=Aramayı tekrar başlat
Expand Down
5 changes: 3 additions & 2 deletions jablib/src/main/resources/l10n/JabRef_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ Convert\ to\ BibTeX\ format\ (e.g.,\ store\ publication\ date\ in\ year\ and\ mo
Deprecated\ fields=废弃的字段

Shows\ fields\ having\ a\ successor\ in\ biblatex.=Shows fields having a successor in biblatex.
Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Clean\ up\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=显示在biblatex中具有后继关系的field。\n例如，发布月份(publication month)应当是日期(date)的一部分。\n使用"清理记录"功能来转换条目为biblatex。
Shows\ fields\ having\ a\ successor\ in\ biblatex.\nFor\ instance,\ the\ publication\ month\ should\ be\ part\ of\ the\ date\ field.\nUse\ the\ Clean\ up\ Entries\ functionality\ to\ convert\ the\ entry\ to\ biblatex.=显示在biblatex中具有后继关系的field。\n例如，发布月份(publication month)应当是日期(date)的一部分。\n使用"清理记录"功能来转换条目为biblatex。


No\ read\ status\ information=无阅读情况信息
Expand Down Expand Up @@ -2709,7 +2709,8 @@ Get\ more\ themes...=获取更多主题...
Miscellaneous=杂项
File-related=文件相关的

The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.\ Lookup\ a\ DOI\ and\ try\ again.=选中的条目并没有链接的 DOI。查找一个 DOI，然后再次尝试。
The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=选中的条目并没有链接的 DOI。
Look\ Up\ a\ DOI\ and\ try\ again.=查找一个 DOI，然后再次尝试。
Cited\ By=被引用
Cites=引用
No\ articles\ found=未找到文章
Expand Down
Loading