Skip to content

Issue 13234 automatic lookup of DOI at citation relations #13539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+224 −186
Open

Issue 13234 automatic lookup of DOI at citation relations #13539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec864d3
Some initial changes + split of the placeholder to label and hyperlink.
ankamde Jul 12, 2025
365b4fa
Commit before switching to different branch.
ankamde Jul 13, 2025
a24dd53
Cited by panel ready.
ankamde Jul 13, 2025
4ef4dd4
Cited by panel ready.
ankamde Jul 13, 2025
af8b918
Finished DOI lookup, add notification about not found DOI.
ankamde Jul 14, 2025
5fa2d72
Add messages to JabRef_en.properties. Modified lang files rolled back.
ankamde Jul 16, 2025
927664c
Merge branch 'main' into issue-13234-automatic-lookup-of-DOI-at-citat…
ankamde Jul 16, 2025
dfdec86
Change "Up" to "up" in the messages.
ankamde Jul 16, 2025
43e1ce7
Remove exclamation from the message.
ankamde Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Added

- We added automatic lookup of DOI at citation relations [#13234](https://github.com/JabRef/jabref/issues/13234)
- We added focus on the field Link in the "Add file link" dialog. [#13486](https://github.com/JabRef/jabref/issues/13486)
- We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189)
- We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842)
Expand Down
19 changes: 19 additions & 0 deletions jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationComponents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package org.jabref.gui.entryeditor.citationrelationtab;

import javafx.scene.control.Button;
import javafx.scene.control.ProgressIndicator;

import org.jabref.logic.importer.fetcher.citation.CitationFetcher;
import org.jabref.model.entry.BibEntry;

import org.controlsfx.control.CheckListView;

public record CitationComponents(
BibEntry entry,
CheckListView<CitationRelationItem> listView,
Button abortButton,
Button refreshButton,
CitationFetcher.SearchType searchType,
Button importButton,
ProgressIndicator progress) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI component (ProgressIndicator) should not be directly included in a data structure. This violates separation of concerns and should be managed in a dedicated UI controller.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simple parameter object - instead passing 7 parameters, use dedicated object.

}
Loading