-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Welcome tab #13407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yubo-Cao
wants to merge
45
commits into
JabRef:main
Choose a base branch
from
Yubo-Cao:welcome-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Welcome tab #13407
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
22e3822
Initial integration of QuickSettings
7958489
Improve the look and feel of theme quick settings
189d030
Remove the unnecessary parameter e from the QuickSettingsButton
aeb258e
Add performance optimization and external application detection setti…
a117f49
Merge remote-tracking branch 'upstream/main' into welcome-tab
47af7fa
Remove the confirmation dialog after quick settings
7be327c
Update CHANGELOG.md
0b34b04
Add online service configuration and citation key removal
2259dfe
Refactor and get consistent language
37449af
Merge remote-tracking branch 'upstream/main' into welcome-tab
a759db9
Allow theme option to be selected by clicking on the WireFrame
ed3a001
Remove usage of JetBrains annotation
e296fd1
Retract change to Base.css
a0af2e8
Fix according to Trag
2e47ab0
Fix CHANGELOG
e8fbd25
Merge remote-tracking branch 'upstream/main' into welcome-tab
196f385
Style change according to the discussion
ff5dcf2
Integrate Walthrough to the WelcomeTab
5eb23ed
Merge remote-tracking branch 'upstream/main' into welcome-tab
5d3d719
Fix according to Trag bot
a831fb2
Slight refactoring and improve the push to application resolution
1b30f7f
Merge branch 'main' into welcome-tab
Yubo-Cao 1309675
Quick fix after the merge
Yubo-Cao 37eaf71
Quick improvement on the elegance of Wireframe styling
Yubo-Cao 792ce4e
Fix the spelling issue with Texmaker
Yubo-Cao 78e8148
Get rid of the qs icon button
Yubo-Cao 6a6485f
Small tweaks
Yubo-Cao 704d76e
Merge remote-tracking branch 'upstream/main' into welcome-tab
Yubo-Cao 3845a44
Replace with modern Java API
Yubo-Cao 5ea5809
Replace with modern Java API
Yubo-Cao e15eede
Fix localization
Yubo-Cao ce7ce88
Implement the new UI interface
Yubo-Cao a1f7aa1
Refactor +change CHANGELOG
Yubo-Cao d127472
Revert a change that breaks the Walkthrough...
Yubo-Cao 64e3829
Continued refactoring
Yubo-Cao 0a3d81f
Apply fix per Trag
Yubo-Cao d28be6b
Apply fix per Trag
Yubo-Cao ab260b4
Apply fix per Trag
Yubo-Cao 6b827c9
Fix Rewrite
Yubo-Cao aadcecb
Fix per Trag
Yubo-Cao 69999b4
Revert walkthrough patches and get in sync with main
Yubo-Cao aa33d51
Address some comments made by Carl
Yubo-Cao 312bd84
Fix according to Trag
Yubo-Cao 89a06a5
Significant refactoring to follow the MVVM style
Yubo-Cao b80ea84
Refactor view model names and fix some Trag comment
Yubo-Cao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
jabgui/src/main/java/org/jabref/gui/util/component/HelpButton.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package org.jabref.gui.util.component; | ||
|
||
import javafx.scene.control.Button; | ||
|
||
import org.jabref.gui.DialogService; | ||
import org.jabref.gui.edit.OpenBrowserAction; | ||
import org.jabref.gui.icon.IconTheme; | ||
import org.jabref.gui.preferences.GuiPreferences; | ||
|
||
import com.airhacks.afterburner.injection.Injector; | ||
import org.jspecify.annotations.NonNull; | ||
|
||
public class HelpButton extends Button { | ||
public HelpButton() { | ||
setGraphic(IconTheme.JabRefIcons.HELP.getGraphicNode()); | ||
getStyleClass().add("icon-button"); | ||
setPrefSize(28, 28); | ||
setMinSize(28, 28); | ||
} | ||
|
||
public HelpButton(@NonNull String url) { | ||
this(); | ||
setHelpPage(url); | ||
} | ||
|
||
public void setHelpPage(@NonNull String helpDocumentationUrl) { | ||
setOnAction( | ||
_ -> new OpenBrowserAction(helpDocumentationUrl, | ||
Injector.instantiateModelOrService(DialogService.class), | ||
Injector.instantiateModelOrService(GuiPreferences.class).getExternalApplicationsPreferences() | ||
).execute() | ||
); | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of line 22 (existing artifact)