-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Welcome tab #13407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Welcome tab #13407
Conversation
jabgui/src/main/java/org/jabref/gui/welcome/QuickSettingsButton.java
Outdated
Show resolved
Hide resolved
…ngs to the welcome tab
Latest update drop:
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java
Outdated
Show resolved
Hide resolved
can you please remove the conflicts |
List<GuiPushToApplication> allApplications = GuiPushToApplications.getAllGUIApplications(dialogService, pushToApplicationPreferences); | ||
|
||
applicationsList.getItems().addAll(allApplications); | ||
applicationsList.setCellFactory(_ -> new PushApplicationListCell(Collections.emptySet())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage of Collections.emptySet() instead of the preferred Set.of() in PushApplicationListCell constructor. JabRef prefers modern Java collection factory methods.
Can you please resolve the conflicts? |
Closes #12664
Video
Steps to test
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)