-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
swiftly 1.0.0 (new formula) #217092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swiftly 1.0.0 (new formula) #217092
Conversation
a6e7709
to
64e0841
Compare
Any idea why the Linux build couldn't locate |
It looks like xclogparser had the same problem 55d4188 + 1024jp/GzipSwift#71 so they had to patch it Apparently, the downstream dependency I don't know what the proper fix should be yet. I've stopped my investigation on checking how they build |
f0a4f4b
to
ebf87a7
Compare
Suggestion: what if we restrict the formula to macOS for now and merge it if there are no other complaints? # On Linux, SPM can't find zlib installed by brew
depends_on :macos At least it will already be available on macOS Later, whoever needs the support for Linux might work on figuring out the zlib problem |
ebf87a7
to
c9c1c40
Compare
I think that's fine for now. I've restricted the formula to macOS as you suggested. Would appreciate your review, @nikitabobko. |
I am not a maintainer of this repo, and I don't have write access. I am just a random guy on the internet who wants this PR merged 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @SimplyDanny! I'm fine with shipping this without Linux support if that's the blocker. Would like to see suggestions applied and a better test before that though.
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?https://github.com/swiftlang/swiftly