Skip to content

swiftly 1.0.0 (new formula) #217092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

SimplyDanny
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://github.com/swiftlang/swiftly

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue labels Mar 29, 2025
@SimplyDanny
Copy link
Contributor Author

Any idea why the Linux build couldn't locate zlib.h even though I've added the dependency?

@chenrui333 chenrui333 added linux Linux is specifically affected CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Mar 31, 2025
@nikitabobko
Copy link

Any idea why the Linux build couldn't locate zlib.h even though I've added the dependency?

It looks like xclogparser had the same problem 55d4188 + 1024jp/GzipSwift#71 so they had to patch it

Apparently, the downstream dependency swift-nio-extras doesn't search C headers in ${brew --prefix}.

I don't know what the proper fix should be yet. I've stopped my investigation on checking how they build swift-nio-extras on Linux on GH Actions + how to add system libraries to SPM https://github.com/swiftlang/swift-package-manager/blob/main/Documentation/Usage.md#requiring-system-libraries

@SimplyDanny SimplyDanny force-pushed the swiftly-1.0.0 branch 2 times, most recently from f0a4f4b to ebf87a7 Compare April 1, 2025 18:02
@nikitabobko
Copy link

nikitabobko commented Apr 13, 2025

Suggestion: what if we restrict the formula to macOS for now and merge it if there are no other complaints?

  # On Linux, SPM can't find zlib installed by brew
  depends_on :macos

At least it will already be available on macOS

Later, whoever needs the support for Linux might work on figuring out the zlib problem

@github-actions github-actions bot added the macos-only Formula depends on macOS label Apr 15, 2025
@SimplyDanny
Copy link
Contributor Author

Suggestion: what if we restrict the formula to macOS for now and merge it if there are no other complaints?

I think that's fine for now. I've restricted the formula to macOS as you suggested. Would appreciate your review, @nikitabobko.

@nikitabobko
Copy link

I am not a maintainer of this repo, and I don't have write access. I am just a random guy on the internet who wants this PR merged 🙂

@p-linnane p-linnane requested a review from a team April 24, 2025 19:36
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @SimplyDanny! I'm fine with shipping this without Linux support if that's the blocker. Would like to see suggestions applied and a better test before that though.

Copy link
Contributor

github-actions bot commented May 5, 2025

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 5, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 5, 2025 19:34
@BrewTestBot BrewTestBot added this pull request to the merge queue May 5, 2025
Merged via the queue into Homebrew:master with commit 89bd44c May 5, 2025
14 checks passed
@SimplyDanny SimplyDanny deleted the swiftly-1.0.0 branch May 5, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. linux Linux is specifically affected macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants