Skip to content

swiftly: add Linux support #224646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

swiftly: add Linux support #224646

merged 2 commits into from
May 26, 2025

Conversation

supertxtnet
Copy link
Contributor

@supertxtnet supertxtnet commented May 24, 2025 •
edited
Loading

Add the necessary SPM arguments for Linux so that swiftly can be
built on that platform. Adjust the test so that it can pass with Linux.
Adjust the test to test swiftly on its own, and not the toolchain it
downloads.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. swift Swift use is a significant feature of the PR or issue no Linux bottle Formula has no Linux bottle labels May 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@supertxtnet supertxtnet marked this pull request as draft May 24, 2025 23:54
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label May 25, 2025
@supertxtnet supertxtnet changed the title Add Linux support to swiftly formula swiftly: add Linux support May 25, 2025
@github-actions github-actions bot removed the python Python use is a significant feature of the PR or issue label May 25, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 25, 2025
@supertxtnet supertxtnet marked this pull request as ready for review May 25, 2025 12:38
@supertxtnet supertxtnet mentioned this pull request May 25, 2025
Merged
SMillerDev
SMillerDev reviewed May 25, 2025
View reviewed changes
@supertxtnet
Copy link
Contributor Author

A previous commit with the exact same code changes was entirely green for CI. There appears to be a transient error in one of the jobs.

@SMillerDev
Copy link
Member

The test is too slow, is there a quicker test we could do?

@supertxtnet
Copy link
Contributor Author

The test is too slow, is there a quicker test we could do?

The test was from the original formula, which involves downloading a swift toolchain. I've reduced the test to only performing a private install of swiftly.

daeho-ro
daeho-ro reviewed May 26, 2025
View reviewed changes
SimplyDanny
SimplyDanny reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great you got this to work!

@supertxtnet supertxtnet force-pushed the add_linux_swiftly branch 2 times, most recently from 5b09a40 to 15229ac Compare May 26, 2025 14:08
@daeho-ro daeho-ro force-pushed the add_linux_swiftly branch from 15229ac to d48ad05 Compare May 26, 2025 14:14
@daeho-ro
Copy link
Member

My bad, there was a style issue and so I added it.

SMillerDev
SMillerDev approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @supertxtnet ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@daeho-ro
Copy link
Member

@supertxtnet I have fixed a syntax but it is reverted. Can you run brew style --fix swiftly? It will fix some code.

@supertxtnet
Copy link
Contributor Author

Thanks @SMillerDev, the libarchive dependency got merged out, so I've added it back in.

@supertxtnet
swiftly: add Linux support
9166687 
* Add SPM arguments for swiftly on Linux with homebrew
* Fix the tests for Linux
* Test swiftly by running its init routine
@supertxtnet
Copy link
Contributor Author

@daeho-ro the checks all seem to pass including the one that you suggested. Is there anything left to do here?

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 26, 2025
@BrewTestBot BrewTestBot enabled auto-merge May 26, 2025 22:32
@github-actions github-actions bot removed the no Linux bottle Formula has no Linux bottle label May 26, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue May 26, 2025
Merged via the queue into Homebrew:master with commit c221da8 May 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimplyDanny SimplyDanny SimplyDanny left review comments

@SMillerDev SMillerDev SMillerDev approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. swift Swift use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@supertxtnet @SMillerDev @daeho-ro @SimplyDanny @BrewTestBot