Skip to content

Conversation

@knoellle
Copy link
Contributor

Why? What?

  • Fixed multiple instances of the x coordinate of the ball position being used by the autoref to determine the field side instead of the y coordinate.
  • Some cleanup, removing unnecessary as_mut and merging some if-lets

Fixes #

ToDo / Known Issues

Ideas for Next Iterations (Not This PR)

How to Test

In the kick_in scenario around frame 6000, a kick in is called but on main the ball is place on the wrong side. This should no longer be the case.

@knoellle knoellle added is:Bugfix tools:Simulator Bevyhavior Simulator, etc labels Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Request for Review in Development Jul 22, 2025
@knoellle knoellle enabled auto-merge July 22, 2025 07:17
Copy link
Member

@rmburg rmburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schaut gut zu mir 👍

@knoellle knoellle added this pull request to the merge queue Aug 14, 2025
Merged via the queue into HULKs:main with commit dfba6fa Aug 14, 2025
27 checks passed
@knoellle knoellle deleted the autoref-side-fixes branch August 14, 2025 06:57
@github-project-automation github-project-automation bot moved this from Request for Review to Done in Development Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:Bugfix tools:Simulator Bevyhavior Simulator, etc

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants