Skip to content

Conversation

@schluis
Copy link
Contributor

@schluis schluis commented Jul 18, 2025

Why? What?

  • Refactor roll_pitch filter in sensor_data_receiver.rs and in orientation_filter.rs

@github-project-automation github-project-automation bot moved this to Request for Review in Development Jul 18, 2025
@schluis schluis added RoboCup 2025 ⚽ is:Refactoring No changes in functionality, only in coding style. labels Jul 18, 2025
@schluis schluis enabled auto-merge July 18, 2025 15:00
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires rebase, there are some major changes in the orientation filter.

@oleflb oleflb self-assigned this Jul 19, 2025
@schluis schluis closed this Jul 19, 2025
auto-merge was automatically disabled July 19, 2025 19:41

Pull request was closed

@github-project-automation github-project-automation bot moved this from Request for Review to Done in Development Jul 19, 2025
@schluis schluis reopened this Jul 19, 2025
@schluis schluis moved this from Done to Request for Review in Development Jul 19, 2025
@schluis schluis enabled auto-merge July 19, 2025 21:13
@rmburg
Copy link
Member

rmburg commented Sep 20, 2025

Me like.

You could go one step further and write something like this, what do you think?

let is_steady = angular_velocity_sum < *context.calibration_steady_threshold

@schluis
Copy link
Contributor Author

schluis commented Oct 1, 2025

@rmburg good Idea, done

@rmburg
Copy link
Member

rmburg commented Oct 1, 2025

I'll approve once you update the other file as well :)

@schluis
Copy link
Contributor Author

schluis commented Oct 1, 2025

Done

@schluis schluis added this pull request to the merge queue Oct 10, 2025
Merged via the queue into HULKs:main with commit 6c1ed64 Oct 10, 2025
27 checks passed
@schluis schluis deleted the refactor-filter branch October 10, 2025 10:21
@github-project-automation github-project-automation bot moved this from Request for Review to Done in Development Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:Refactoring No changes in functionality, only in coding style.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants