-
Notifications
You must be signed in to change notification settings - Fork 57
Refactor filter #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor filter #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleflb
requested changes
Jul 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires rebase, there are some major changes in the orientation filter.
auto-merge was automatically disabled
July 19, 2025 19:41
Pull request was closed
|
Me like. You could go one step further and write something like this, what do you think? let is_steady = angular_velocity_sum < *context.calibration_steady_threshold |
5421953 to
e5761f5
Compare
|
@rmburg good Idea, done |
|
I'll approve once you update the other file as well :) |
e5761f5 to
ef707da
Compare
|
Done |
rmburg
approved these changes
Oct 1, 2025
oleflb
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
roll_pitchfilter insensor_data_receiver.rsand inorientation_filter.rs