Skip to content

fix(retail): add region tag for Java - Update search with filtering #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix(retail): add region tag for Java - Update search with filtering #10128

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b60adfb
Update SearchWithPagination.java
rebeccaellis Jun 11, 2025
24e9ac1
Merge pull request #2 from rebeccaellis/rebeccaellis-patch-search-wit…
rebeccaellis Jun 11, 2025
009b2e2
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 13, 2025
8a99d05
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 17, 2025
50ac4d1
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jun 27, 2025
7ebb204
Merge branch 'GoogleCloudPlatform:main' into main
rebeccaellis Jul 8, 2025
7013e58
Update SearchWithFiltering.java
rebeccaellis Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions retail/interactive-tutorials/src/main/java/search/SearchWithFiltering.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
*/

package search;
// [START retail_search_for_products_with_filtering]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other sample files in this directory (e.g., SearchSimpleQuery.java and SearchWithPagination.java) and to adhere to common Java styling conventions, please add a blank line between the package declaration and this // [START ...] region tag.1

The common convention in this repository and a general best practice is to separate the package declaration from the rest of the file with a blank line, which improves readability.

The desired format is:

package ...;

// [START ...]

import ...;

Style Guide References

Footnotes

  1. The Google Java Style Guide (section 4.6.1 on blank lines) recommends a single blank line to separate logical sections of a source file, such as between the package statement and import statements or class declarations. ↩


import com.google.cloud.ServiceOptions;
import com.google.cloud.retail.v2.SearchRequest;
Expand Down Expand Up @@ -71,3 +72,5 @@ public static void searchResponse(String defaultSearchPlacementName) throws IOEx
}
}
}

// [END retail_search_for_products_with_filtering]