Skip to content

fix undefined behavior #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix undefined behavior #75

wants to merge 1 commit into from
+1 −1

Conversation

selimsandal
Copy link
Contributor

@selimsandal selimsandal commented Jul 3, 2025 •
edited
Loading

When win32 is not defined this line causes undefined behavior:

CMake Error at External/D3D12MemoryAllocator/src/CMakeLists.txt:174 (if):
  if given arguments:

    "OFF" "AND"

  Unknown arguments specified

I think expanding variables is not needed here.

@sawickiap
Copy link
Contributor

Thank you for this contribution. For now I merged it to my fork at https://github.com/sawickiap/D3D12MemoryAllocator

@sawickiap sawickiap mentioned this pull request Jul 3, 2025
Merged
@selimsandal selimsandal deleted the patch-1 branch July 14, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selimsandal @sawickiap @jlacroixAMD