Skip to content

fix: clear traits when identifying over previous identity #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2024
Merged

fix: clear traits when identifying over previous identity #229

merged 3 commits into from
May 17, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 17, 2024 •
edited
Loading

Clears out traits when identifying over previous identity.

@kyle-ssg kyle-ssg linked an issue May 17, 2024 that may be closed by this pull request
Identifier/trait confusion when using cacheOptions: { skipAPI: true } #227
Closed
@kyle-ssg kyle-ssg requested review from rolodato and novakzaballa May 17, 2024 13:47
@matthewelwell
Copy link
Contributor

I've reviewed the code (which looks sound) and tested this manually using 4.0.2-beta-1 and @rolodato 's test example code here.

@matthewelwell matthewelwell merged commit 1a47754 into main May 17, 2024
1 check passed
@matthewelwell matthewelwell deleted the fix/clear-traits-when-identifying-over-previous-identity branch May 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@rolodato rolodato Awaiting requested review from rolodato

@novakzaballa novakzaballa Awaiting requested review from novakzaballa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifier/trait confusion when using cacheOptions: { skipAPI: true }
2 participants
@kyle-ssg @matthewelwell