fix: clear traits when identifying over previous identity (#229)

* Clear traits on Initialise over old identity

* Fix tests

* bump version

Author: kyle-ssg

flagsmith-core.ts

@@ -506,6 +506,10 @@ const Flagsmith = class {
     }
 
     identify(userId: string, traits?: ITraits) {
+        if(this.identity && this.identity !== userId) {
+            // clear out old traits when switching identity
+            this.withTraits = {}
+        }
         this.identity = userId;
         this.log("Identify: " + this.identity)
 

lib/flagsmith-es/package.json

@@ -1,6 +1,6 @@
 {
   "name": "flagsmith-es",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "Feature flagging to support continuous development. This is an esm equivalent of the standard flagsmith npm module.",
   "main": "./index.js",
   "type": "module",

lib/flagsmith/package.json

@@ -1,6 +1,6 @@
 {
   "name": "flagsmith",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "repository": {

lib/react-native-flagsmith/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-flagsmith",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "repository": {

test/init.test.ts

@@ -70,4 +70,19 @@ describe('Flagsmith.init', () => {
         const {flagsmith,initConfig} = getFlagsmith({onChange, environmentID:"bad"})
         await expect(flagsmith.init(initConfig)).rejects.toThrow(Error);
     });
+    test('identifying with new identity should not carry over previous traits for different identity', async () => {
+        const onChange = jest.fn()
+        const now = Date.now();
+        const identityA = `test_identity_a_${now}`
+        const identityB = `test_identity_b_${now}`
+        const {flagsmith,initConfig} = getFlagsmith({onChange, identity:identityA, traits: {a:`example`}})
+        await flagsmith.init(initConfig);
+        expect(flagsmith.getTrait("a")).toEqual(`example`)
+        await flagsmith.identify(identityB)
+        expect(flagsmith.getTrait("a")).toEqual(undefined)
+        await flagsmith.identify(identityA)
+        expect(flagsmith.getTrait("a")).toEqual(`example`)
+        await flagsmith.identify(identityB)
+        expect(flagsmith.getTrait("a")).toEqual(undefined)
+    });
 });