Don't print 'Node Graph out of Date' messages in non-developer mode #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we forced printing it because when nodes wasn't shipped with the game for some reason, nodes generation without this iconic message make the game look like it's frozen. |
|
I think the message stays for too long, longer than the node graph building usually takes. And there's no way to control the duration. But it's up to you. |
|
Player knows when nodes generation is finished :) |
Platform/CPU/Optflags-specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that in Valve repo the message printing is commented out https://github.com/ValveSoftware/halflife/blob/master/dlls/nodes.cpp#L1490
As a compromise we can still print it, but only in developer mode.