-
Notifications
You must be signed in to change notification settings - Fork 39
Fix FDP v2 index API #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FDP v2 index API #637
Conversation
by updatedAt, createdAt, and lastRetrievalAt, respectively.
This handles the exception globally, via ExceptionControllerAdvice. Alternatively, we could do this on the controller level, adding the method to the IndexEntryController.
The error sub-issue: |
these were accidentally changed to Instant in previous commits, to match other DTOs, but that results in a Unix timestamp , whereas we want to exchange ISO 8601 dates
although still too broad: this does not rule out internal causes...
Now we can click FDP links and delete FDPs, but we get the following after "Trigger ping":
UPDATE: forgot to initialize the |
based on an explicit list of allowed fields IndexEntryController.sortFields also remove the handleUnknownField controller advice, which was too broadly scoped
(precommit hook not working...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍🏻
Changes:
registrationTime
,modificationTime
, andlastRetrievalTime
, bycreatedAt
,updatedAt
, andlastRetrievalAt
, respectively, conforming to changes made in Migrate to PostgreSQL #519IndexEntry.events
to specify cascading and orphan removalIndexEntry.lastRetrievalAt
inEventService.processMetadataRetrieval
and in test fixturesort
url query parametersThis fixes the following: