Skip to content

Adapt to FDP v2 property names #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Adapt to FDP v2 property names #170

merged 1 commit into from
Mar 10, 2025

Conversation

dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Mar 4, 2025

renamed as follows:

  • modificationTime -> updatedAt
  • registrationTime -> createdAt
  • lastRetrievalTime -> lastRetrievalAt

todo (maybe unrelated issues):

fixes #169

rename as follows:
- `modificationTime` -> `updatedAt`
- `registrationTime` -> `createdAt`
- `lastRetrievalTime` -> `lastRetrievalAt`
@dennisvang
Copy link
Contributor Author

dennisvang commented Mar 4, 2025

Using this together with FDP c59d52d2 (to be part of v2.0.0), the index list page is rendered properly, as long as the list of FDPs is empty.

screenshot of empty list

However, if we register an FDP via "Trigger ping" we run into the next issue on the API side, which is:

java.lang.NullPointerException: 
    Cannot invoke "java.time.Instant.isAfter(java.time.Instant)" because "lastRetrievalAt" is null

@dennisvang dennisvang changed the title adapt to fdp v2 instant names Adapt to FDP v2 instant names Mar 4, 2025
@dennisvang
Copy link
Contributor Author

dennisvang commented Mar 4, 2025

The NullPointerException mentioned above is fixed with the latest FAIRDataTeam/FAIRDataPoint#637

image

@dennisvang dennisvang marked this pull request as ready for review March 4, 2025 17:03
@dennisvang dennisvang changed the title Adapt to FDP v2 instant names Adapt to FDP v2 property names Mar 6, 2025
@dennisvang dennisvang requested a review from MarekSuchanek March 7, 2025 16:46
@dennisvang dennisvang merged commit fd416bd into develop Mar 10, 2025
3 checks passed
@dennisvang dennisvang deleted the fix/issue169 branch March 10, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get FAIR Data Points from FDP v2 index
2 participants