-
-
Notifications
You must be signed in to change notification settings - Fork 398
refactor(radio): move per10ms() to a software timer #5966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4649e58
to
64c057b
Compare
64c057b
to
ad6b9a0
Compare
How accurate / consistent will this be? Could this adversely affect the 'g_rtcTime' variable that is updated every second in the per10ms() function. If the interval between calls is not exactly 10ms then g_rtcTime value will not accurately reflect the time. |
No different from what we're doing right. The current implementation schedules the This PR just replaces the async scheduling with a fixed timer call, which reduces the pressure on the timer task's request queue. As far as I could see, this is really no different from the previous implementation, except that it the timer task's queue is not flooded in case the timer task is not scheduled as often as required. |
Thanks. |
It is just used to fire things "from time to time", not at all for timing related activities, so inaccurate timing is no issue there |
This helps reducing the pressure on the timer queue.
ad6b9a0
to
9341e13
Compare
@philmoz @gagarinlg @pfeerick @3djc we'd need to decide whether or not to include this in 2.11. If that is not the case (and it's really not necessary as of now), I'd squash it with the rest of #5840 and keep only that PR open. |
3.0 is the way to go imho |
There are a couple of users having issues with 2.11 and switches not working or UI not working. Could this solve those issues? |
Per10ms don't handle those, so very unlikely |
Closed in favour of #5840 |
This helps reducing the pressure on the timer queue.