Add getTokenDetails to currency tools
#658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
May 19, 2025
src/core/account/custom-tokens.ts
Outdated
Comment on lines
36
to
50
| /** | ||
| * Query the network for a token's details | ||
| */ | ||
| export async function getTokenDetails( | ||
| ai: ApiInput, | ||
| pluginId: string, | ||
| filter: EdgeGetTokenDetails | ||
| ): Promise<EdgeToken[]> { | ||
| // The normal code path: | ||
| const tools = await getCurrencyTools(ai, pluginId) | ||
| if (tools.getTokenDetails == null) return [] | ||
|
|
||
| return await tools.getTokenDetails(filter) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is simple enough, I would just put it inline in plugin-api.ts. There is no real logic in this function, just a wrapper around a tools method.
This was referenced May 19, 2025
samholmes
previously requested changes
May 22, 2025
src/types/types.ts
Outdated
| /** | ||
| * Search the blockchain for a token. | ||
| */ | ||
| export interface EdgeGetTokenDetails { |
There was a problem hiding this comment.
Also, shouldn't this be named EdgeGetTokenDetailsParams or EdgeGetTokenDetailsFilter?
samholmes
force-pushed
the
matthew/get-token-details
branch
from
8a3f1a0 to
99582c9
Compare
peachbits
force-pushed
the
matthew/get-token-details
branch
from
c86d5a8 to
ee2855d
Compare
peachbits
dismissed
samholmes’s stale review
changes accepted. dismissed review to merge while reviewer is OOO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none