Use getTokenDetails in EditTokenScene
#5586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
May 20, 2025
| } | ||
|
|
||
| if (item.key === 'contractAddress') { | ||
| autoCompleteToken(value).catch(console.error) |
There was a problem hiding this comment.
Ok, so in the other PR's, we talked about hiding errors in at the plugin level. We might even do that here too (.catch(() => [])), so we don't bother logging the errors to the console. It could be quite spammy if the internet is down.
| return | ||
| } | ||
|
|
||
| const [token] = await wallet.currencyConfig.getTokenDetails({ contractAddress: searchString }) |
There was a problem hiding this comment.
We need some way to rate-limit this call, so we don't spam the network as the user types. The simplest way is a busy flag, so if one call is pending, we don't trigger any more until after that one finishes.
There was a problem hiding this comment.
I added a pretty basic rate limiter. There are obvious race conditions but since this is a field the user would most likely paste a value in I'm not concerned about it.
peachbits
force-pushed
the
matthew/get-token-details
branch
from
31a42de to
c4d5fba
Compare
swansontec
approved these changes
May 27, 2025
Specifically, if a field called "contractAddress' exists put it at the top
peachbits
force-pushed
the
matthew/get-token-details
branch
from
c4d5fba to
a739dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#658
EdgeApp/edge-currency-accountbased#936
Requirements
If you have made any visual changes to the GUI. Make sure you have: