Duress login fixes #650
Merged
Duress login fixes #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/duress-login
branch
from
389b43a to
e744119
Compare
swansontec
approved these changes
May 8, 2025
Comment on lines
+195
to
+199
| const duressSessionKey = decryptChildKey( | ||
| stash, | ||
| sessionKey, | ||
| duressStash.loginId | ||
| ) |
There was a problem hiding this comment.
I don't think this is needed - the root sessionKey will be fine. On the whiteboard diagram, the core knows how to handle the green arrow (the session key) being on a lower node than the orange arrow (the appId). It just does decryptChildKey as-needed to handle the difference.
However, the way you are doing it does protect the root account from modifications, since we don't have a root decryption key. If that's the goal, then carry on! That's fine.
There was a problem hiding this comment.
Less changes now, means less tests now. I'll save face for this reason and the one you mentioned.
swansontec
approved these changes
May 8, 2025
samholmes
force-pushed
the
sam/duress-login
branch
from
f6ad17d to
49d6e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none