Sam/duress biometric #651
Merged
Sam/duress biometric #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/duress-biometric
branch
2 times, most recently
from
7b80c71 to
f31f122
Compare
swansontec
requested changes
May 8, 2025
src/core/account/account-api.ts
Outdated
Comment on lines
157
to
163
| // If we're in duress mode, we need to use the duress session key | ||
| // to return the loginKey: | ||
| if (this.isDuressAccount) { | ||
| return base58.stringify(sessionKey.loginKey) | ||
| } | ||
|
|
||
| // Maybe we could just always return the loginKey from sessionKey? |
There was a problem hiding this comment.
Yes, just always return return base58.stringify(login.loginKey). The green arrow (the session key) can point to nodes below us, but we want to return the key for the orange arrow (the current appId).
If we want to return the green arrow, we'd need to update the login-ui to store which appId it goes with, because that could be different from login to login. We aren't planning to make such a big change here.
swansontec
approved these changes
May 8, 2025
samholmes
force-pushed
the
sam/duress-biometric
branch
from
48fa434 to
727089b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
#650
Description
none