Add MPAS-O and MPAS-SI from EarthWorksOrg/EarthWorks #4807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpas-seaice does not run with optimization. These changes prevent compiler optimization using the gnu compilers for mpas-seaice.
The seaice file that fails with gnu optimization is identified. This file is modified to restrict non-optimization to just this file.
Changes to prevent optimization flags from being applied to ice_shortwave.F90 from mpas-seaice (PR#2) had incorrect whitespace before the build rule. This change corrects the spacing.
These modifications permit the mpas-ocean to access the gpu compiler flags necessary for a gpu build.
Catch up to development, especially to cesm3_0_beta06 version.
This was referenced Jun 12, 2025
|
Some help reviewing from @jedwards4b would be appreciated! (Can't assign reviewers.) |
|
This is part of a collection of PRs to enable MPAS-O and MPAS-SI in CESM: |
This was referenced Jun 12, 2025
jedwards4b
requested changes
Jun 13, 2025
There was a problem hiding this comment.
The changes to config_files.xml are fine, but I would prefer that the changes in Makefile be removed to https://github.com/ESMCI/ccs_config_cesm/blob/main/machines/Depends.nvhpc
Gotcha, I'll test out moving that over. |
These rules for MPAS-Ocean and MPAS-SeaIce are better handled in the Depends.* files for each compiler than in cime:CIME/Tools/Makefile.
|
@jedwards4b do these recent changes here and in ccs_config_cesm address your request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request edits some config_*.xml files and the Makefile so
that MPAS Ocean and MPAS SeaIce can be used as components of a
model in CESM.
These components have been forked from E3SM development for use
in the EarthWorks project (EarthWorksOrg/Earthworks on GitHub).
Adding these components with CESM is part of a long-held
EarthWorks goal to share our developments to run atmosphere, ocean,
seaice, and land models on shared MPAS grids while utilizing GPUs.
Test suite: aux_cmeps
Test baseline: cesm3_0_beta06
Test namelist changes: only
model_versionreported diff. while testingTest status: bit for bit
Fixes #4806
User interface changes?: N
Update gh-pages html (Y/N)?: unsure, likely N