Skip to content

Conversation

@duncanpharvey
Copy link
Contributor

What does this PR do?

Updates rustls-native-certs to 0.8.1.

Motivation

connector::tests::test_missing_root_certificates_only_allow_http_connections test fails when run from ddcommon directory.

--- STDERR:              ddcommon connector::tests::test_missing_root_certificates_only_allow_http_connections ---
thread 'connector::tests::test_missing_root_certificates_only_allow_http_connections' panicked at ddcommon/src/connector/mod.rs:231:9:
assertion failed: matches!(connector, Connector::Http(_))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

        PASS [   1.250s] ddcommon connector::tests::test_hyper_client_from_connector
------------
     Summary [   1.286s] 58 tests run: 57 passed, 1 failed, 0 skipped
        FAIL [   1.218s] ddcommon connector::tests::test_missing_root_certificates_only_allow_http_connections
error: test run failed

Additional Notes

How to test the change?

cd ddcommon
cargo nextest run --no-fail-fast

@duncanpharvey duncanpharvey marked this pull request as ready for review April 21, 2025 15:17
@duncanpharvey duncanpharvey requested a review from a team as a code owner April 21, 2025 15:17
@r1viollet
Copy link
Contributor

r1viollet commented Apr 21, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.77 MB 7.70 MB --.82% (-65.72 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.74 MB 23.71 MB --.12% (-31.47 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 76.99 MB 76.92 MB --.09% (-72.17 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.35 MB 22.31 MB --.16% (-38.50 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.63 MB 7.63 MB --.01% (-1.56 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.35 MB 71.26 MB --.12% (-88.62 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.74 MB 16.73 MB --.09% (-15.50 KB) 💪
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 112.85 MB 112.73 MB --.11% (-128.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 633.24 MB 632.28 MB --.15% (-984.68 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 4.99 MB 4.99 MB --.10% (-5.50 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.89 MB 15.86 MB --.19% (-32.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.43 MB 26.39 MB --.16% (-44.80 KB) 💪
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.15 MB 14.14 MB --.11% (-16.50 KB) 💪
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 114.77 MB 114.61 MB --.14% (-168.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 624.98 MB 624.67 MB --.04% (-319.37 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.77 MB --.12% (-5.00 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.51 MB 16.47 MB --.23% (-40.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.35 MB 24.31 MB --.16% (-41.26 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.35 MB 66.28 MB --.10% (-72.51 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.19 MB 8.18 MB --.06% (-5.54 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.92 MB 22.89 MB --.11% (-27.21 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.32 MB 67.25 MB --.09% (-67.08 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.08 MB 8.07 MB --.11% (-9.57 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.56 MB 20.54 MB --.12% (-26.53 KB) 💪

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (8c82620) to head (1a1bb6d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   71.51%   71.56%   +0.05%     
==========================================
  Files         339      339              
  Lines       50649    50668      +19     
==========================================
+ Hits        36222    36263      +41     
+ Misses      14427    14405      -22     
Components Coverage Δ
crashtracker 42.82% <ø> (ø)
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.83% <ø> (-0.19%) ⬇️
data-pipeline-ffi 90.30% <ø> (ø)
ddcommon 78.57% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.19% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.51% <ø> (+0.10%) ⬆️
profiling 77.49% <ø> (ø)
profiling-ffi 62.12% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.81% <ø> (+0.67%) ⬆️
sidecar-ffi 7.29% <ø> (+5.25%) ⬆️
spawn-worker 54.37% <ø> (ø)
tinybytes 89.86% <ø> (ø)
trace-mini-agent 73.80% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 92.99% <ø> (-0.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-21 15:28:53

Comparing candidate commit 1a1bb6d in PR branch duncan-harvey/rustls-native-certs-0.8.1 with baseline commit 8c82620 in branch main.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 45 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+5.867µs; +6.041µs] or [+7.562%; +7.787%]
  • 🟥 throughput [-932360.415op/s; -905289.239op/s] or [-7.233%; -7.023%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+8.525µs; +8.650µs] or [+11.935%; +12.109%]
  • 🟥 throughput [-1513159.163op/s; -1491656.142op/s] or [-10.808%; -10.655%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+9.087µs; +9.217µs] or [+13.387%; +13.578%]
  • 🟥 throughput [-1763234.268op/s; -1737680.511op/s] or [-11.968%; -11.795%]

scenario:ip_address/quantize_peer_ip_address_benchmark

  • 🟥 execution_time [+684.058ns; +697.358ns] or [+13.384%; +13.645%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.916µs 3.919µs 3.926µs 0.34% -0.779 8.695 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254686135.210op/s 255552539.530op/s ± 196815.474op/s 255554128.034op/s ± 102203.220op/s 255642711.507op/s 255904494.366op/s 256048320.642op/s 256763265.977op/s 0.47% 0.802 8.767 0.08% 13916.956op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 82.204µs 83.534µs ± 0.443µs 83.580µs ± 0.313µs 83.873µs 84.213µs 84.315µs 84.396µs 0.98% -0.436 -0.238 0.53% 0.031µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11848941.401op/s 11971569.299op/s ± 63578.209op/s 11964577.672op/s ± 44796.329op/s 12013277.374op/s 12085618.335op/s 12119738.010op/s 12164922.284op/s 1.67% 0.461 -0.197 0.53% 4495.658op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.654µs 80.017µs ± 0.351µs 80.050µs ± 0.197µs 80.225µs 80.545µs 80.748µs 80.829µs 0.97% -0.669 1.112 0.44% 0.025µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12371763.237op/s 12497512.610op/s ± 54953.194op/s 12492139.745op/s ± 30712.063op/s 12527303.774op/s 12591034.430op/s 12665903.861op/s 12713911.562op/s 1.78% 0.705 1.197 0.44% 3885.778op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.924µs 0.28% -0.912 8.350 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254813518.076op/s 255524494.070op/s ± 178355.564op/s 255520775.783op/s ± 101742.406op/s 255628841.325op/s 255726671.650op/s 256028880.824op/s 256646295.618op/s 0.44% 0.932 8.445 0.07% 12611.643op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 75.920µs 77.031µs ± 0.306µs 77.070µs ± 0.168µs 77.227µs 77.420µs 77.542µs 78.432µs 1.77% -0.042 2.981 0.40% 0.022µs 1 200
credit_card/is_card_number/378282246310005 throughput 12749856.736op/s 12981952.364op/s ± 51599.427op/s 12975154.535op/s ± 28315.482op/s 13009030.550op/s 13068411.698op/s 13124595.074op/s 13171771.758op/s 1.52% 0.101 2.877 0.40% 3648.631op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.329µs 51.434µs ± 0.033µs 51.435µs ± 0.020µs 51.452µs 51.487µs 51.518µs 51.558µs 0.24% 0.048 1.257 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19395485.487op/s 19442322.921op/s ± 12598.289op/s 19442120.806op/s ± 7627.845op/s 19450849.163op/s 19464256.035op/s 19476539.255op/s 19482020.044op/s 0.21% -0.042 1.255 0.06% 890.834op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.029µs 6.038µs ± 0.003µs 6.038µs ± 0.002µs 6.040µs 6.043µs 6.045µs 6.047µs 0.16% -0.108 0.461 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165359887.783op/s 165624799.222op/s ± 89630.984op/s 165620187.649op/s ± 55232.847op/s 165678428.669op/s 165757445.776op/s 165855726.271op/s 165877356.069op/s 0.16% 0.112 0.462 0.05% 6337.868op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.919µs 3.927µs 0.38% -0.402 6.282 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254640314.332op/s 255608483.401op/s ± 203344.109op/s 255601261.233op/s ± 107483.035op/s 255714083.462op/s 255921781.820op/s 256065877.221op/s 256744900.396op/s 0.45% 0.421 6.316 0.08% 14378.600op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.994µs 66.550µs ± 0.335µs 66.499µs ± 0.182µs 66.707µs 67.122µs 67.355µs 68.675µs 3.27% 1.659 7.153 0.50% 0.024µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14561312.786op/s 15026640.485op/s ± 75025.282op/s 15037740.217op/s ± 41208.372op/s 15072934.918op/s 15123349.008op/s 15141719.898op/s 15152904.933op/s 0.77% -1.566 6.463 0.50% 5305.089op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.433µs 59.613µs ± 0.082µs 59.612µs ± 0.054µs 59.665µs 59.754µs 59.792µs 59.951µs 0.57% 0.313 0.601 0.14% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16680373.366op/s 16774771.735op/s ± 23076.581op/s 16775007.755op/s ± 15289.737op/s 16790498.677op/s 16812979.789op/s 16823472.850op/s 16825800.683op/s 0.30% -0.303 0.577 0.14% 1631.761op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.928µs 0.36% -1.085 19.591 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254590447.041op/s 255512783.690op/s ± 162067.204op/s 255509332.513op/s ± 80254.673op/s 255601424.979op/s 255702177.314op/s 255733435.794op/s 256738249.027op/s 0.48% 1.123 19.758 0.06% 11459.882op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.256µs 56.588µs ± 0.154µs 56.582µs ± 0.098µs 56.681µs 56.876µs 56.972µs 57.073µs 0.87% 0.356 0.048 0.27% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17521322.806op/s 17671600.782op/s ± 48119.524op/s 17673564.785op/s ± 30630.713op/s 17704065.739op/s 17748103.306op/s 17764678.121op/s 17776006.649op/s 0.58% -0.340 0.028 0.27% 3402.564op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.328µs 51.440µs ± 0.033µs 51.440µs ± 0.018µs 51.456µs 51.491µs 51.529µs 51.645µs 0.40% 1.163 7.347 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19362935.588op/s 19439968.063op/s ± 12421.654op/s 19440034.298op/s ± 6819.395op/s 19447428.254op/s 19455157.322op/s 19467718.108op/s 19482481.353op/s 0.22% -1.148 7.264 0.06% 878.344op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.038µs ± 0.005µs 6.038µs ± 0.002µs 6.040µs 6.045µs 6.050µs 6.066µs 0.47% 1.530 8.132 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 164844768.855op/s 165609864.218op/s ± 128408.529op/s 165620229.017op/s ± 60734.241op/s 165678234.026op/s 165772489.952op/s 165925257.145op/s 165955006.463op/s 0.20% -1.512 8.034 0.08% 9079.854op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255525262.798op/s; 255579816.262op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [83.472µs; 83.595µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11962757.971op/s; 11980380.627op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.969µs; 80.066µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12489896.626op/s; 12505128.594op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255499775.704op/s; 255549212.436op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.989µs; 77.074µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/378282246310005 throughput [12974801.180op/s; 12989103.548op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.430µs; 51.439µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19440576.919op/s; 19444068.922op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [165612377.229op/s; 165637221.214op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255580301.863op/s; 255636664.939op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.504µs; 66.597µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15016242.703op/s; 15037038.268op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.602µs; 59.625µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16771573.543op/s; 16777969.928op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255490322.734op/s; 255535244.646op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.567µs; 56.610µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17664931.879op/s; 17678269.685op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.436µs; 51.445µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19438246.541op/s; 19441689.584op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.038µs; 6.039µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165592068.031op/s; 165627660.405op/s] or [-0.011%; +0.011%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.380µs 67.654µs ± 0.207µs 67.649µs ± 0.077µs 67.711µs 67.781µs 68.048µs 69.830µs 3.22% 7.201 67.821 0.31% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.626µs; 67.683µs] or [-0.042%; +0.042%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.843ns 253.188ns ± 11.776ns 247.905ns ± 3.118ns 253.708ns 282.253ns 284.306ns 285.506ns 15.17% 1.532 1.032 4.64% 0.833ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.556ns; 254.821ns] or [-0.645%; +0.645%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 71.839ms 72.160ms ± 0.199ms 72.109ms ± 0.135ms 72.295ms 72.528ms 72.624ms 72.678ms 0.79% 0.629 -0.595 0.28% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.132ms; 72.187ms] or [-0.038%; +0.038%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.828µs 505.321µs ± 1.076µs 505.208µs ± 0.295µs 505.513µs 506.060µs 506.733µs 518.177µs 2.57% 9.090 102.557 0.21% 0.076µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1929843.747op/s 1978949.494op/s ± 4133.303op/s 1979384.599op/s ± 1154.729op/s 1980464.206op/s 1982003.540op/s 1982727.673op/s 1984805.213op/s 0.27% -8.951 100.223 0.21% 292.269op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 461.259µs 462.181µs ± 0.306µs 462.184µs ± 0.185µs 462.371µs 462.665µs 462.888µs 463.227µs 0.23% -0.025 0.611 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2158769.547op/s 2163654.639op/s ± 1433.189op/s 2163641.810op/s ± 868.142op/s 2164477.691op/s 2165896.328op/s 2167379.869op/s 2167981.605op/s 0.20% 0.031 0.610 0.07% 101.342op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.308µs 177.682µs ± 0.147µs 177.684µs ± 0.087µs 177.770µs 177.906µs 178.027µs 178.155µs 0.26% 0.002 0.290 0.08% 0.010µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5613088.957op/s 5628023.152op/s ± 4650.592op/s 5627960.256op/s ± 2740.168op/s 5630726.518op/s 5637151.491op/s 5638412.114op/s 5639918.185op/s 0.21% 0.004 0.287 0.08% 328.847op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.520µs 37.621µs ± 0.041µs 37.617µs ± 0.024µs 37.641µs 37.702µs 37.736µs 37.757µs 0.37% 0.633 0.687 0.11% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26485052.031op/s 26580618.563op/s ± 28856.354op/s 26583427.997op/s ± 16833.838op/s 26599978.368op/s 26620440.350op/s 26636958.474op/s 26652311.561op/s 0.26% -0.626 0.676 0.11% 2040.452op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.164µs 48.317µs ± 0.201µs 48.301µs ± 0.025µs 48.332µs 48.370µs 48.442µs 51.057µs 5.71% 12.832 172.514 0.41% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19586018.343op/s 20696977.924op/s ± 81643.606op/s 20703485.620op/s ± 10863.574op/s 20712433.575op/s 20729826.278op/s 20751881.346op/s 20762458.832op/s 0.28% -12.707 170.215 0.39% 5773.075op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.172µs; 505.470µs] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978376.658op/s; 1979522.330op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [462.139µs; 462.224µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2163456.013op/s; 2163853.265op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.662µs; 177.703µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5627378.625op/s; 5628667.679op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.616µs; 37.627µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26576619.350op/s; 26584617.776op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.289µs; 48.345µs] or [-0.058%; +0.058%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20685662.906op/s; 20708292.943op/s] or [-0.055%; +0.055%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.675µs 149.267µs ± 0.743µs 149.123µs ± 0.140µs 149.286µs 149.951µs 150.718µs 158.226µs 6.10% 9.076 104.169 0.50% 0.053µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.164µs; 149.370µs] or [-0.069%; +0.069%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.405µs 2.425µs ± 0.022µs 2.419µs ± 0.009µs 2.428µs 2.488µs 2.496µs 2.502µs 3.41% 2.024 3.518 0.91% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.422µs; 2.428µs] or [-0.127%; +0.127%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.195µs 3.220µs ± 1.502µs 2.996µs ± 0.026µs 3.022µs 3.686µs 13.942µs 16.534µs 451.89% 7.463 57.310 46.53% 0.106µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.012µs; 3.428µs] or [-6.465%; +6.465%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.920ms 5.931ms ± 0.005ms 5.930ms ± 0.003ms 5.933ms 5.937ms 5.948ms 5.972ms 0.69% 3.107 19.262 0.09% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.930ms; 5.932ms] or [-0.013%; +0.013%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.747µs 5.802µs ± 0.027µs 5.789µs ± 0.014µs 5.821µs 5.850µs 5.855µs 5.857µs 1.17% 0.681 -0.857 0.46% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.798µs; 5.805µs] or [-0.064%; +0.064%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.221µs 25.237µs ± 10.653µs 17.672µs ± 0.365µs 33.500µs 42.611µs 52.810µs 94.806µs 436.49% 2.096 8.838 42.11% 0.753µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.761µs; 26.714µs] or [-5.850%; +5.850%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.226µs 33.016µs ± 1.039µs 32.394µs ± 0.096µs 34.247µs 35.008µs 35.078µs 35.315µs 9.02% 1.010 -0.780 3.14% 0.073µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.872µs; 33.160µs] or [-0.436%; +0.436%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1a1bb6d 1745248505 duncan-harvey/rustls-native-certs-0.8.1
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.731µs 209.090µs ± 0.136µs 209.091µs ± 0.087µs 209.179µs 209.323µs 209.385µs 209.410µs 0.15% -0.151 0.099 0.06% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4775310.372op/s 4782641.127op/s ± 3114.656op/s 4782615.194op/s ± 1998.572op/s 4784440.362op/s 4788263.461op/s 4790183.700op/s 4790846.290op/s 0.17% 0.155 0.101 0.06% 220.239op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.597µs 18.661µs ± 0.030µs 18.657µs ± 0.012µs 18.674µs 18.704µs 18.727µs 18.931µs 1.47% 3.583 29.553 0.16% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52822820.175op/s 53586604.713op/s ± 86829.000op/s 53599501.813op/s ± 33851.046op/s 53627082.495op/s 53707960.016op/s 53743366.247op/s 53771623.712op/s 0.32% -3.493 28.543 0.16% 6139.737op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.946µs 11.003µs ± 0.028µs 11.004µs ± 0.019µs 11.023µs 11.044µs 11.058µs 11.100µs 0.87% 0.068 0.091 0.26% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90093648.883op/s 90885661.048op/s ± 234711.623op/s 90877919.166op/s ± 159812.065op/s 91035729.249op/s 91298764.260op/s 91339146.927op/s 91355005.552op/s 0.52% -0.052 0.065 0.26% 16596.618op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.071µs; 209.108µs] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782209.466op/s; 4783072.789op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.657µs; 18.666µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53574571.048op/s; 53598638.377op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.999µs; 11.007µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good throughput [90853132.275op/s; 90918189.822op/s] or [-0.036%; +0.036%] None None None

Baseline

Omitted due to size.

@duncanpharvey duncanpharvey enabled auto-merge (squash) April 21, 2025 15:34
@duncanpharvey duncanpharvey merged commit ac445fa into main Apr 21, 2025
35 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/rustls-native-certs-0.8.1 branch April 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants