fix(ddcommon): Add ubuntu ssl cert directory for unit test #1034

duncanpharvey · 2025-04-21T18:51:00Z

What does this PR do?

Add ubuntu ssl cert directory for test_missing_root_certificates_only_allow_http_connections.

Motivation

Test test_missing_root_certificates_only_allow_http_connections failing on ubuntu when ddcommon feature use_webpki_roots is disabled.

Additional Notes

Follows #1033

Since trace-mini-agent imports trace-utils with the mini_agent feature enabled, the use_webpki_roots feature is enabled for test runs. This means that test_missing_root_certificates_use_webpki_certificates runs in CI while test_missing_root_certificates_only_allow_http_connections does not run in CI, resulting in this test failure being hidden from past PRs.

Following #1030 the default behavior will be to run test_missing_root_certificates_only_allow_http_connections in CI.

How to test the change?

Validated by applying this change and running CI in #1030.
https://github.com/DataDog/libdatadog/actions/runs/14579303934/job/40892263238?pr=1030

…_allow_http_connections

pr-commenter · 2025-04-21T18:54:18Z

Benchmarks

Comparison

Benchmark execution time: 2025-04-21 18:53:53

Comparing candidate commit 15c760d in PR branch duncan-harvey/ssl-cert-dir-ubuntu with baseline commit ac445fa in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

🟩 execution_time [-9.357µs; -9.299µs] or [-13.575%; -13.491%]
🟩 throughput [+2264031.470op/s; +2276936.123op/s] or [+15.606%; +15.695%]

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	72.383ms	72.817ms ± 0.316ms	72.729ms ± 0.149ms	72.990ms	73.447ms	73.876ms	74.277ms	2.13%	1.580	3.288	0.43%	0.022ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[72.773ms; 72.861ms] or [-0.060%; +0.060%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
ip_address/quantize_peer_ip_address_benchmark	execution_time	4.948µs	5.029µs ± 0.047µs	5.034µs ± 0.042µs	5.073µs	5.101µs	5.109µs	5.110µs	1.51%	-0.019	-1.203	0.93%	0.003µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark	execution_time	[5.022µs; 5.035µs] or [-0.129%; +0.129%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	31.405µs	32.384µs ± 1.223µs	31.629µs ± 0.056µs	33.821µs	34.662µs	34.719µs	35.105µs	10.99%	0.977	-0.917	3.77%	0.086µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[32.214µs; 32.553µs] or [-0.523%; +0.523%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	17.423µs	25.802µs ± 11.282µs	17.708µs ± 0.104µs	34.876µs	44.905µs	46.181µs	89.755µs	406.85%	1.824	6.114	43.61%	0.798µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[24.239µs; 27.366µs] or [-6.060%; +6.060%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	246.135ns	256.073ns ± 11.373ns	250.447ns ± 2.594ns	258.733ns	285.721ns	287.294ns	287.848ns	14.93%	1.575	1.364	4.43%	0.804ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[254.496ns; 257.649ns] or [-0.616%; +0.616%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
concentrator/add_spans_to_concentrator	execution_time	5.939ms	5.950ms ± 0.005ms	5.949ms ± 0.002ms	5.952ms	5.957ms	5.973ms	5.990ms	0.68%	2.936	17.452	0.09%	0.000ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
concentrator/add_spans_to_concentrator	execution_time	[5.949ms; 5.951ms] or [-0.012%; +0.012%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	504.046µs	505.341µs ± 0.744µs	505.271µs ± 0.212µs	505.521µs	506.038µs	506.335µs	514.258µs	1.78%	8.625	101.228	0.15%	0.053µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	1944549.444op/s	1978866.685op/s ± 2879.135op/s	1979137.472op/s ± 829.878op/s	1979898.911op/s	1981365.631op/s	1982724.587op/s	1983945.691op/s	0.24%	-8.498	99.239	0.15%	203.586op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	454.156µs	455.320µs ± 0.462µs	455.279µs ± 0.296µs	455.653µs	456.101µs	456.454µs	456.538µs	0.28%	0.188	-0.074	0.10%	0.033µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	2190396.491op/s	2196259.013op/s ± 2229.910op/s	2196457.411op/s ± 1427.389op/s	2197732.402op/s	2199831.833op/s	2201320.687op/s	2201885.607op/s	0.25%	-0.182	-0.075	0.10%	157.678op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	175.976µs	177.564µs ± 0.409µs	177.656µs ± 0.082µs	177.745µs	177.934µs	178.005µs	178.134µs	0.27%	-2.267	4.371	0.23%	0.029µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	5613736.073op/s	5631812.657op/s ± 13046.404op/s	5628869.676op/s ± 2610.029op/s	5631042.620op/s	5667343.640op/s	5676201.506op/s	5682582.842op/s	0.95%	2.276	4.404	0.23%	922.520op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	37.598µs	37.702µs ± 0.043µs	37.694µs ± 0.024µs	37.723µs	37.779µs	37.824µs	37.854µs	0.43%	0.743	1.053	0.11%	0.003µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	26416979.939op/s	26523959.505op/s ± 30536.432op/s	26529262.076op/s ± 17207.124op/s	26543140.589op/s	26565823.004op/s	26590412.305op/s	26597487.154op/s	0.26%	-0.734	1.037	0.11%	2159.252op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	48.190µs	48.311µs ± 0.045µs	48.306µs ± 0.029µs	48.338µs	48.369µs	48.444µs	48.602µs	0.61%	1.617	8.514	0.09%	0.003µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	20575385.993op/s	20699353.182op/s ± 19115.477op/s	20701561.816op/s ± 12330.679op/s	20711501.261op/s	20724632.294op/s	20736152.013op/s	20751041.502op/s	0.24%	-1.596	8.361	0.09%	1351.668op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[505.238µs; 505.444µs] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[1978467.665op/s; 1979265.706op/s] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[455.256µs; 455.384µs] or [-0.014%; +0.014%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[2195949.969op/s; 2196568.057op/s] or [-0.014%; +0.014%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[177.507µs; 177.620µs] or [-0.032%; +0.032%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[5630004.551op/s; 5633620.763op/s] or [-0.032%; +0.032%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[37.696µs; 37.708µs] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[26519727.450op/s; 26528191.561op/s] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[48.305µs; 48.317µs] or [-0.013%; +0.013%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[20696703.961op/s; 20702002.403op/s] or [-0.013%; +0.013%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	208.865µs	209.173µs ± 0.129µs	209.168µs ± 0.085µs	209.254µs	209.392µs	209.521µs	209.575µs	0.19%	0.312	0.247	0.06%	0.009µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	4771570.980op/s	4780739.621op/s ± 2940.678op/s	4780843.162op/s ± 1938.506op/s	4782746.720op/s	4785403.657op/s	4787136.295op/s	4787770.757op/s	0.14%	-0.308	0.242	0.06%	207.937op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	18.563µs	18.648µs ± 0.030µs	18.649µs ± 0.019µs	18.669µs	18.696µs	18.723µs	18.730µs	0.44%	-0.045	0.415	0.16%	0.002µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	53389703.208op/s	53624680.811op/s ± 86918.405op/s	53623554.919op/s ± 55989.081op/s	53677512.330op/s	53767380.079op/s	53853519.386op/s	53871143.876op/s	0.46%	0.057	0.417	0.16%	6146.059op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	10.919µs	10.973µs ± 0.038µs	10.966µs ± 0.035µs	11.002µs	11.035µs	11.066µs	11.073µs	0.98%	0.345	-0.856	0.35%	0.003µs	1	200
normalization/normalize_name/normalize_name/good	throughput	90306500.262op/s	91137716.336op/s ± 316956.222op/s	91190506.124op/s ± 289799.876op/s	91449443.599op/s	91549885.700op/s	91578060.314op/s	91582510.558op/s	0.43%	-0.335	-0.873	0.35%	22412.189op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[209.155µs; 209.191µs] or [-0.009%; +0.009%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[4780332.071op/s; 4781147.171op/s] or [-0.009%; +0.009%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[18.644µs; 18.652µs] or [-0.022%; +0.022%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[53612634.756op/s; 53636726.866op/s] or [-0.022%; +0.022%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[10.967µs; 10.978µs] or [-0.048%; +0.048%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[91093789.252op/s; 91181643.420op/s] or [-0.048%; +0.048%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	1.163µs	3.165µs ± 1.411µs	2.975µs ± 0.026µs	2.998µs	3.624µs	13.854µs	14.777µs	396.69%	7.396	55.668	44.48%	0.100µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[2.970µs; 3.361µs] or [-6.179%; +6.179%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	67.363µs	67.570µs ± 0.253µs	67.549µs ± 0.038µs	67.586µs	67.659µs	67.959µs	70.991µs	5.10%	12.415	164.633	0.37%	0.018µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[67.535µs; 67.605µs] or [-0.052%; +0.052%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	3.894µs	3.914µs ± 0.003µs	3.914µs ± 0.001µs	3.915µs	3.919µs	3.921µs	3.922µs	0.21%	-1.487	12.810	0.07%	0.000µs	1	200
credit_card/is_card_number/	throughput	254967781.888op/s	255491236.648op/s ± 183982.750op/s	255507365.815op/s ± 95907.750op/s	255594242.745op/s	255685964.180op/s	255937789.378op/s	256820617.029op/s	0.51%	1.515	13.015	0.07%	13009.545op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	82.913µs	84.214µs ± 0.496µs	84.262µs ± 0.229µs	84.467µs	84.671µs	84.879µs	88.666µs	5.23%	3.157	31.161	0.59%	0.035µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	11278284.563op/s	11874912.027op/s ± 68738.692op/s	11867702.074op/s ± 32208.602op/s	11904274.826op/s	11987881.179op/s	12041073.015op/s	12060845.852op/s	1.63%	-2.767	27.178	0.58%	4860.560op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	78.714µs	80.035µs ± 0.491µs	80.011µs ± 0.228µs	80.261µs	80.600µs	80.748µs	84.646µs	5.79%	3.893	37.358	0.61%	0.035µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	11813882.963op/s	12495043.991op/s ± 75001.008op/s	12498272.832op/s ± 35642.610op/s	12527486.594op/s	12597914.075op/s	12657443.257op/s	12704202.409op/s	1.65%	-3.468	32.630	0.60%	5303.372op/s	1	200
credit_card/is_card_number/37828224631	execution_time	3.893µs	3.914µs ± 0.003µs	3.914µs ± 0.001µs	3.915µs	3.918µs	3.920µs	3.923µs	0.24%	-1.891	16.337	0.07%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	254918119.522op/s	255519934.091op/s ± 179485.117op/s	255521720.922op/s ± 78906.691op/s	255598977.604op/s	255723362.503op/s	255959095.049op/s	256885480.634op/s	0.53%	1.922	16.577	0.07%	12691.514op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	76.111µs	76.982µs ± 0.270µs	77.013µs ± 0.179µs	77.174µs	77.373µs	77.455µs	77.474µs	0.60%	-0.610	0.161	0.35%	0.019µs	1	200
credit_card/is_card_number/378282246310005	throughput	12907562.442op/s	12990254.513op/s ± 45618.619op/s	12984767.333op/s ± 30177.408op/s	13017910.685op/s	13072731.407op/s	13105315.457op/s	13138671.051op/s	1.19%	0.629	0.197	0.35%	3225.723op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	51.355µs	51.438µs ± 0.032µs	51.438µs ± 0.020µs	51.459µs	51.485µs	51.501µs	51.553µs	0.22%	-0.119	0.614	0.06%	0.002µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	19397378.171op/s	19440854.143op/s ± 11953.925op/s	19440756.239op/s ± 7716.837op/s	19448294.764op/s	19462723.727op/s	19470944.872op/s	19472343.431op/s	0.16%	0.124	0.612	0.06%	845.270op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	6.054µs	6.065µs ± 0.004µs	6.065µs ± 0.002µs	6.068µs	6.071µs	6.075µs	6.077µs	0.21%	0.159	1.241	0.06%	0.000µs	1	200
credit_card/is_card_number/x371413321323331	throughput	164542826.886op/s	164875001.085op/s ± 99512.799op/s	164885556.025op/s ± 49380.592op/s	164922775.838op/s	165040380.899op/s	165127668.527op/s	165168398.648op/s	0.17%	-0.153	1.239	0.06%	7036.617op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	3.896µs	3.913µs ± 0.003µs	3.913µs ± 0.001µs	3.915µs	3.916µs	3.918µs	3.919µs	0.15%	-1.478	6.843	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	255179056.628op/s	255572504.193op/s ± 175421.618op/s	255556580.942op/s ± 96432.599op/s	255650075.485op/s	255875543.418op/s	255972747.546op/s	256679491.268op/s	0.44%	1.492	6.940	0.07%	12404.182op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	65.892µs	66.328µs ± 0.208µs	66.297µs ± 0.121µs	66.450µs	66.682µs	66.946µs	67.269µs	1.47%	0.974	2.005	0.31%	0.015µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	14865659.234op/s	15076807.395op/s ± 47061.367op/s	15083548.378op/s ± 27508.382op/s	15108983.052op/s	15142620.194op/s	15157941.661op/s	15176324.773op/s	0.62%	-0.946	1.899	0.31%	3327.741op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	59.408µs	59.602µs ± 0.078µs	59.599µs ± 0.056µs	59.654µs	59.735µs	59.780µs	59.784µs	0.31%	0.081	-0.388	0.13%	0.006µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	16726991.699op/s	16778081.326op/s ± 21967.663op/s	16778816.745op/s ± 15794.704op/s	16794581.648op/s	16811765.466op/s	16824848.384op/s	16832635.113op/s	0.32%	-0.075	-0.388	0.13%	1553.348op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	3.894µs	3.913µs ± 0.003µs	3.914µs ± 0.001µs	3.915µs	3.917µs	3.919µs	3.920µs	0.17%	-2.099	13.498	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	255086612.683op/s	255528722.597op/s ± 176123.023op/s	255521158.957op/s ± 84004.268op/s	255607693.793op/s	255843734.661op/s	255975483.269op/s	256819817.085op/s	0.51%	2.122	13.692	0.07%	12453.778op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	56.301µs	56.584µs ± 0.132µs	56.576µs ± 0.094µs	56.674µs	56.827µs	56.930µs	56.960µs	0.68%	0.367	-0.047	0.23%	0.009µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	17556212.861op/s	17672836.141op/s ± 41205.151op/s	17675399.402op/s ± 29372.392op/s	17702031.759op/s	17733997.582op/s	17750741.938op/s	17761721.984op/s	0.49%	-0.354	-0.061	0.23%	2913.644op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	51.336µs	51.430µs ± 0.043µs	51.432µs ± 0.024µs	51.453µs	51.494µs	51.546µs	51.621µs	0.37%	0.284	1.354	0.08%	0.003µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	19371961.024op/s	19443912.256op/s ± 16393.246op/s	19443283.942op/s ± 9103.950op/s	19452666.314op/s	19472897.329op/s	19478531.230op/s	19479503.666op/s	0.19%	-0.275	1.331	0.08%	1159.178op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	6.056µs	6.066µs ± 0.004µs	6.066µs ± 0.002µs	6.068µs	6.072µs	6.079µs	6.103µs	0.60%	3.303	26.780	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	163866445.170op/s	164840434.954op/s ± 113956.410op/s	164848633.167op/s ± 44482.546op/s	164888494.907op/s	164978533.083op/s	165102763.888op/s	165133713.745op/s	0.17%	-3.266	26.408	0.07%	8057.935op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[3.914µs; 3.914µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/	throughput	[255465738.408op/s; 255516734.888op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[84.145µs; 84.283µs] or [-0.082%; +0.082%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[11865385.505op/s; 11884438.548op/s] or [-0.080%; +0.080%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[79.967µs; 80.103µs] or [-0.085%; +0.085%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[12484649.572op/s; 12505438.409op/s] or [-0.083%; +0.083%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[3.913µs; 3.914µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[255495059.180op/s; 255544809.002op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[76.944µs; 77.019µs] or [-0.049%; +0.049%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[12983932.211op/s; 12996576.815op/s] or [-0.049%; +0.049%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[51.434µs; 51.442µs] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[19439197.444op/s; 19442510.842op/s] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[6.065µs; 6.066µs] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[164861209.568op/s; 164888792.602op/s] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[3.912µs; 3.913µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[255548192.443op/s; 255596815.942op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[66.299µs; 66.356µs] or [-0.043%; +0.043%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[15070285.142op/s; 15083329.648op/s] or [-0.043%; +0.043%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[59.591µs; 59.612µs] or [-0.018%; +0.018%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[16775036.819op/s; 16781125.833op/s] or [-0.018%; +0.018%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[3.913µs; 3.914µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[255504313.640op/s; 255553131.554op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[56.566µs; 56.603µs] or [-0.032%; +0.032%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[17667125.503op/s; 17678546.778op/s] or [-0.032%; +0.032%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[51.424µs; 51.436µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[19441640.309op/s; 19446184.202op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[6.066µs; 6.067µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[164824641.692op/s; 164856228.217op/s] or [-0.010%; +0.010%]	None	None	None

Group 12

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	2.331µs	2.388µs ± 0.018µs	2.388µs ± 0.005µs	2.393µs	2.411µs	2.416µs	2.498µs	4.63%	-0.022	9.565	0.74%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[2.386µs; 2.390µs] or [-0.103%; +0.103%]	None	None	None

Group 13

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`15c760d`	1745260815	duncan-harvey/ssl-cert-dir-ubuntu

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	148.144µs	149.340µs ± 0.320µs	149.332µs ± 0.166µs	149.509µs	149.854µs	150.150µs	150.739µs	0.94%	0.308	2.444	0.21%	0.023µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[149.296µs; 149.385µs] or [-0.030%; +0.030%]	None	None	None

Baseline

Omitted due to size.

r1viollet · 2025-04-21T19:02:27Z

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	76.92 MB	76.92 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.70 MB	7.70 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug	23.71 MB	23.71 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug	22.31 MB	22.31 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	7.63 MB	7.63 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	71.26 MB	71.26 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	16.73 MB	16.73 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	61.83 KB	61.83 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	112.72 MB	112.71 MB	-0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	632.28 MB	632.28 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	4.99 MB	4.99 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	61.83 KB	61.83 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	15.86 MB	15.86 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	26.39 MB	26.39 MB	0% (0 B) 👌

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	14.14 MB	14.14 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	62.78 KB	62.78 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	114.61 MB	114.61 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	624.67 MB	624.67 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	3.77 MB	3.77 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	62.78 KB	62.78 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	16.47 MB	16.47 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	24.31 MB	24.31 MB	0% (0 B) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	66.28 MB	66.28 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.18 MB	8.18 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug	22.89 MB	22.89 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	67.25 MB	67.25 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	8.07 MB	8.07 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug	20.54 MB	20.54 MB	0% (0 B) 👌

codecov-commenter · 2025-04-21T19:04:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.58%. Comparing base (ac445fa) to head (15c760d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   71.59%   71.58%   -0.02%     
==========================================
  Files         339      339              
  Lines       50668    50668              
==========================================
- Hits        36275    36269       -6     
- Misses      14393    14399       +6

Components	Coverage Δ
crashtracker	`42.73% <ø> (-0.09%)`	⬇️
crashtracker-ffi	`6.30% <ø> (ø)`
datadog-alloc	`98.73% <ø> (ø)`
data-pipeline	`90.83% <ø> (ø)`
data-pipeline-ffi	`90.30% <ø> (ø)`
ddcommon	`78.57% <ø> (ø)`
ddcommon-ffi	`66.37% <ø> (ø)`
ddtelemetry	`60.19% <ø> (ø)`
ddtelemetry-ffi	`21.32% <ø> (ø)`
dogstatsd-client	`82.57% <ø> (ø)`
ipc	`82.41% <ø> (ø)`
profiling	`77.49% <ø> (ø)`
profiling-ffi	`62.12% <ø> (ø)`
serverless	`0.00% <ø> (ø)`
sidecar	`41.81% <ø> (ø)`
sidecar-ffi	`7.29% <ø> (ø)`
spawn-worker	`54.37% <ø> (ø)`
tinybytes	`89.86% <ø> (ø)`
trace-mini-agent	`73.80% <ø> (ø)`
trace-normalization	`98.24% <ø> (ø)`
trace-obfuscation	`96.00% <ø> (ø)`
trace-protobuf	`78.50% <ø> (ø)`
trace-utils	`92.99% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

add ubuntu ssl cert directory for test_missing_root_certificates_only…

15c760d

…_allow_http_connections

github-actions bot added the common label Apr 21, 2025

duncanpharvey marked this pull request as ready for review April 21, 2025 19:05

duncanpharvey requested a review from a team as a code owner April 21, 2025 19:05

ekump approved these changes Apr 21, 2025

View reviewed changes

duncanpharvey merged commit a303dc1 into main Apr 21, 2025
35 checks passed

duncanpharvey deleted the duncan-harvey/ssl-cert-dir-ubuntu branch April 21, 2025 19:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ddcommon): Add ubuntu ssl cert directory for unit test #1034

fix(ddcommon): Add ubuntu ssl cert directory for unit test #1034

Uh oh!

duncanpharvey commented Apr 21, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Apr 21, 2025 •

edited

Loading

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

Uh oh!

r1viollet commented Apr 21, 2025

Uh oh!

codecov-commenter commented Apr 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix(ddcommon): Add ubuntu ssl cert directory for unit test #1034

fix(ddcommon): Add ubuntu ssl cert directory for unit test #1034

Uh oh!

Conversation

duncanpharvey commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

pr-commenter bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Comparison

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

Baseline

Uh oh!

r1viollet commented Apr 21, 2025

Artifact Size Benchmark Report

Uh oh!

codecov-commenter commented Apr 21, 2025

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

duncanpharvey commented Apr 21, 2025 •

edited

Loading

pr-commenter bot commented Apr 21, 2025 •

edited

Loading