Skip to content

🔧 Improve manual deploy job #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2025
+7 −5
Merged

🔧 Improve manual deploy job #3934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f03ad0a
🛠️ Remove dependency on previous step in create-github-release step
thomas-lebeau Oct 28, 2025
45da158
🔧 skip initial monitor checks in deploy script when needed
thomas-lebeau Oct 28, 2025
a41d780
🔧 Update deploy script to skip monitor checks when upload path is 'root'
thomas-lebeau Oct 28, 2025
592ec23
🔧 Set create-github-release step to manual trigger in deploy script
thomas-lebeau Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitlab/deploy-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,10 @@ step-6_publish-developer-extension:
- node ./scripts/deploy/publish-developer-extension.ts

step-7_create-github-release:
needs:
- step-6_publish-developer-extension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: add when: manual, else the release will be created as soon as we reach the "deploy" stage, without waiting for anything to finish.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!

stage: deploy
extends:
- .base-configuration
when: manual
allow_failure: false
script:
- yarn
Expand Down
9 changes: 6 additions & 3 deletions scripts/deploy/deploy-prod-dc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@ const GATE_INTERVAL = ONE_MINUTE_IN_SECOND

const version: string = process.argv[2]
const uploadPath: string = process.argv[3]
const withGateMonitors: boolean = process.argv[4] === 'true'
const withMonitorChecks: boolean = process.argv[4] === 'true'

runMain(async () => {
command`node ./scripts/deploy/check-monitors.ts ${uploadPath}`.withLogs().run()
if (withMonitorChecks) {
command`node ./scripts/deploy/check-monitors.ts ${uploadPath}`.withLogs().run()
}

command`node ./scripts/deploy/deploy.ts prod ${version} ${uploadPath}`.withLogs().run()
command`node ./scripts/deploy/upload-source-maps.ts ${version} ${uploadPath}`.withLogs().run()

if (withGateMonitors && uploadPath !== 'root') {
if (withMonitorChecks && uploadPath !== 'root') {
await gateMonitors(uploadPath)
}
})
Expand Down