🔧 Improve manual deploy job #3934
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| runMain(async () => { | ||
| command`node ./scripts/deploy/check-monitors.ts ${uploadPath}`.withLogs().run() | ||
| if (withMonitorChecks) { | ||
| command`node ./scripts/deploy/check-monitors.ts ${uploadPath}`.withLogs().run() | ||
| } | ||
|
|
||
| command`node ./scripts/deploy/deploy.ts prod ${version} ${uploadPath}`.withLogs().run() | ||
| command`node ./scripts/deploy/upload-source-maps.ts ${version} ${uploadPath}`.withLogs().run() | ||
|
|
||
| if (withGateMonitors && uploadPath !== 'root') { | ||
| if (withMonitorChecks) { | ||
| await gateMonitors(uploadPath) | ||
| } |
There was a problem hiding this comment.
deploy-prod-dc.ts now runs gateMonitors(uploadPath) whenever withMonitorChecks is true, whereas the previous version explicitly skipped gating when the upload path was root. .gitlab/deploy-auto.yml passes true for all DCs, but check-monitors.ts has no monitor IDs configured for root, so the gate loop simply logs “No monitors configured” once per minute and waits out the full 30‑minute timeout. This change makes every automatic GOV deployment block for 30 minutes without providing any checks, noticeably slowing the release pipeline.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
good point @codex, can you fix this?
There was a problem hiding this comment.
Summary
- Added a guard to skip the post-deploy monitor gating loop whenever the upload path is
root, restoring the previous behavior for GOV deployments while preserving the initial optional monitor check. scripts/deploy/deploy-prod-dc.tsL15-L27
Testing
⚠️ Tests not run (not requested)
There was a problem hiding this comment.
@codex, address this feedback in this PR, no need to create a separate PR for this
There was a problem hiding this comment.
Summary
- Skipped the post-deploy monitor gating loop when the upload path is
root, preventing GOV deployments from waiting out the 30-minute timeout while preserving the initial optional monitor check. scripts/deploy/deploy-prod-dc.tsL22-L27
Testing
⚠️ Tests not run (not requested)
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 592ec23 | Docs | Was this helpful? Give us feedback! |
|
|
||
| step-7_create-github-release: | ||
| needs: | ||
| - step-6_publish-developer-extension |
There was a problem hiding this comment.
Suggestion: add when: manual, else the release will be created as soon as we reach the "deploy" stage, without waiting for anything to finish.
There was a problem hiding this comment.
good catch, thank you!
Motivation
In some instance we need to be able to force deploy manually, ignoring monitor checks (e.g. hotfix)
Changes
Test instructions
Checklist